Summary: | Regression: Bug 14828 broke display of localized item type descriptions | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | brendan, gmcharlt, jonathan.druart, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/catalogue/itemsearch.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14828 | ||
Bug Blocks: | |||
Attachments: |
Bug 16114: Koha::ItemType->translated_description should return a string
[SIGNED-OFF] Bug 16114: Koha::ItemType->translated_description should return a string [PASSED QA] Bug 16114: Koha::ItemType->translated_description should return a string |
Description
Owen Leonard
2016-03-21 18:19:32 UTC
Created attachment 49410 [details] [review] Bug 16114: Koha::ItemType->translated_description should return a string This patch fixes a regression introduce by bug 14828. If an itemtype is translated, its description won't be displayed correctly on the item search form. Koha::ItemType->translated_description is only used once. Test plan: - define a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages) - go on the item search form, the item type should be displayed correctly. QA note: This module is not covered by tests, it seems that I forgot to write them... Created attachment 49415 [details] [review] [SIGNED-OFF] Bug 16114: Koha::ItemType->translated_description should return a string This patch fixes a regression introduce by bug 14828. If an itemtype is translated, its description won't be displayed correctly on the item search form. Koha::ItemType->translated_description is only used once. Test plan: - define a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages) - go on the item search form, the item type should be displayed correctly. QA note: This module is not covered by tests, it seems that I forgot to write them... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 49416 [details] [review] [PASSED QA] Bug 16114: Koha::ItemType->translated_description should return a string This patch fixes a regression introduce by bug 14828. If an itemtype is translated, its description won't be displayed correctly on the item search form. Koha::ItemType->translated_description is only used once. Test plan: - define a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages) - go on the item search form, the item type should be displayed correctly. QA note: This module is not covered by tests, it seems that I forgot to write them... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release. Thanks! Does not concern stable versions, status changed to RESOLVED |