Bug 16114

Summary: Regression: Bug 14828 broke display of localized item type descriptions
Product: Koha Reporter: Owen Leonard <oleonard>
Component: System AdministrationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: brendan, gmcharlt, jonathan.druart, julian.maurice
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/catalogue/itemsearch.pl
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14828    
Bug Blocks:    
Attachments: Bug 16114: Koha::ItemType->translated_description should return a string
[SIGNED-OFF] Bug 16114: Koha::ItemType->translated_description should return a string
[PASSED QA] Bug 16114: Koha::ItemType->translated_description should return a string

Description Owen Leonard 2016-03-21 18:19:32 UTC
If you have defined a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages), the item type description is not displayed correctly in the item search form (catalogue/itemsearch.pl). Instead you see something like "Koha::Localization=HASH(0x849c980)"
Comment 1 Jonathan Druart 2016-03-22 09:50:45 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-03-22 14:21:52 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-03-22 22:28:33 UTC
Created attachment 49416 [details] [review]
[PASSED QA] Bug 16114: Koha::ItemType->translated_description should return a string

This patch fixes a regression introduce by bug 14828.
If an itemtype is translated, its description won't be displayed
correctly on the item search form.

Koha::ItemType->translated_description is only used once.

Test plan:
- define a translation for an item type (Administration ->
  Item types -> Edit -> Translate into other languages)
- go on the item search form, the item type should be displayed
  correctly.

QA note: This module is not covered by tests, it seems that I forgot to
write them...

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-03-23 01:06:34 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-03-23 07:24:15 UTC
Does not concern stable versions, status changed to RESOLVED