Summary: | Making action on patron search a button | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Patrons | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, gmcharlt, jonathan.druart, kyle.m.hall, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | Sponsored | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 16120: Making 'Edit' on patron search a button
Bug 16120: Making 'Edit' on patron search a button Bug 16120: Making 'Edit' on patron search a button [PASSED QA] Bug 16120: Making 'Edit' on patron search a button Bug 16120: Making 'Edit' on patron search a button Bug 16120: Add the actions class to all actions td [PASSED QA] Bug 16120: Making 'Edit' on patron search a button [PASSED QA] Bug 16120: Add the actions class to all actions td |
Description
Aleisha Amohia
2016-03-22 03:19:29 UTC
Created attachment 49408 [details] [review] Bug 16120: Making 'Edit' on patron search a button To test: 1) Go to Patrons and do a search that will bring up more than one result 2) Confirm 'Edit' now shows as a font awesome button and works as expected Sponsored-by: Catalyst IT The table cell containing the button needs an "action" class. Created attachment 49420 [details] [review] Bug 16120: Making 'Edit' on patron search a button EDIT: Adding nowrap styles to the Action column. I chose to do it with a span because that's the way it's already done in this file for another column. To test: 1) Go to Patrons and do a search that will bring up more than one result 2) Confirm 'Edit' now shows as a font awesome button and works as expected 3) Confirm the button does not wrap when you make your browser narrower Sponsored-by: Catalyst IT Created attachment 49429 [details] [review] Bug 16120: Making 'Edit' on patron search a button EDIT: Adding nowrap styles to the Action column. I chose to do it with a span because that's the way it's already done in this file for another column. To test: 1) Go to Patrons and do a search that will bring up more than one result 2) Confirm 'Edit' now shows as a font awesome button and works as expected 3) Confirm the button does not wrap when you make your browser narrower Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49467 [details] [review] [PASSED QA] Bug 16120: Making 'Edit' on patron search a button EDIT: Adding nowrap styles to the Action column. I chose to do it with a span because that's the way it's already done in this file for another column. To test: 1) Go to Patrons and do a search that will bring up more than one result 2) Confirm 'Edit' now shows as a font awesome button and works as expected 3) Confirm the button does not wrap when you make your browser narrower Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Working on a counter patch. Created attachment 49475 [details] [review] Bug 16120: Making 'Edit' on patron search a button EDIT: Adding nowrap styles to the Action column. I chose to do it with a span because that's the way it's already done in this file for another column. To test: 1) Go to Patrons and do a search that will bring up more than one result 2) Confirm 'Edit' now shows as a font awesome button and works as expected 3) Confirm the button does not wrap when you make your browser narrower Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 49476 [details] [review] Bug 16120: Add the actions class to all actions td We have several others places where a td contains buttons. This patch fixes the ones in table generated server-side. Test plan: Search for patrons and shelves: the buttons should not wrap Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #6) > Working on a counter patch. Just a follow-up finally. Created attachment 49478 [details] [review] [PASSED QA] Bug 16120: Making 'Edit' on patron search a button EDIT: Adding nowrap styles to the Action column. I chose to do it with a span because that's the way it's already done in this file for another column. To test: 1) Go to Patrons and do a search that will bring up more than one result 2) Confirm 'Edit' now shows as a font awesome button and works as expected 3) Confirm the button does not wrap when you make your browser narrower Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 49479 [details] [review] [PASSED QA] Bug 16120: Add the actions class to all actions td We have several others places where a td contains buttons. This patch fixes the ones in table generated server-side. Test plan: Search for patrons and shelves: the buttons should not wrap Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release. Thanks! |