Summary: | Regression: Can't add messages at checkout if no other messages are present | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, gmcharlt, jonathan.druart, julian.maurice, kyle.m.hall, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/circulation.pl?borrowernumber=X | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15632 | ||
Bug Blocks: | |||
Attachments: |
Bug 16125: Remove the flagged boolean in circ/circulation.tt
Bug 16125: Remove the flagged boolean in circ/circulation.tt [PASSED QA] Bug 16125: Remove the flagged boolean in circ/circulation.tt |
Description
Owen Leonard
2016-03-22 16:07:30 UTC
Created attachment 49450 [details] [review] Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. Created attachment 49454 [details] [review] Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49463 [details] [review] [PASSED QA] Bug 16125: Remove the flagged boolean in circ/circulation.tt Before 15632, flagged was passed in any cases: GetMessages returned an arrayref, so: my $bor_messages_loop = GetMessages( $borrowernumber, 'B', $branch ); if($bor_messages_loop){ $template->param(flagged => 1 ); } set 'flagged'. It seems that this variable is not needed as it's always set. Test plan: Confirm that the "Add a new message" link is always displayed (even if no message exist). Note that a "Attention" is displayed but should not, that already existed before bug 15632. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release. Thanks! Not needed in 3.22.x, status changed to RESOLVED |