| Summary: | Remove URL::Encode dependency | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | OPAC | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | brendan, julian.maurice, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11622 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16129: Remove URL::Encode dependency
Bug 16129: Remove URL::Encode dependency Bug 16129: Remove URL::Encode dependency |
||
|
Description
Tomás Cohen Arazi (tcohen)
2016-03-22 23:04:02 UTC
Created attachment 49419 [details] [review] Bug 16129: Remove URL::Encode dependency This patch makes the PayPal integration feature independent from the URL::Encode library, which is absent in some supported distributions. It uses the URI package which is already a Koha dependency. To test: - Apply the patch - Notice there are no deps for URL::Encode - Follow the steps from the original patch => SUCCESS: It works as expected - Sign-off :-D Note: I deleted the line in which $amount_to_pay was url-encoded, because that's one of the things query_form does (and the variable is only used as a parameter to it). Sponsored-by: Bywater Solutions Created attachment 49743 [details] [review] Bug 16129: Remove URL::Encode dependency This patch makes the PayPal integration feature independent from the URL::Encode library, which is absent in some supported distributions. It uses the URI package which is already a Koha dependency. To test: - Apply the patch - Notice there are no deps for URL::Encode - Follow the steps from the original patch => SUCCESS: It works as expected - Sign-off :-D Note: I deleted the line in which $amount_to_pay was url-encoded, because that's one of the things query_form does (and the variable is only used as a parameter to it). Sponsored-by: ByWater Solutions Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Worked as advertised Created attachment 49791 [details] [review] Bug 16129: Remove URL::Encode dependency This patch makes the PayPal integration feature independent from the URL::Encode library, which is absent in some supported distributions. It uses the URI package which is already a Koha dependency. To test: - Apply the patch - Notice there are no deps for URL::Encode - Follow the steps from the original patch => SUCCESS: It works as expected - Sign-off :-D Note: I deleted the line in which $amount_to_pay was url-encoded, because that's one of the things query_form does (and the variable is only used as a parameter to it). Sponsored-by: ByWater Solutions Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good move Tomas, works as advertised, removes the dependency without causing any issues. Pushed to Master - Should be in the 2016 release. Thanks! Not needed in stable versions, status changed to RESOLVED |