| Summary: | Making dictionary 'Delete' a font awesome button | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Reports | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | brendan, jonathan.druart, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16161 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16162: Making dictionary 'Delete' a button
Bug 16162: Making dictionary 'Delete' a button Bug 16162: Making dictionary 'Delete' a button Bug 16162: Making dictionary 'Delete' a button Bug 16162: Making dictionary 'Delete' a button [PASSED QA] Bug 16162: Making dictionary 'Delete' a button |
||
|
Description
Aleisha Amohia
2016-03-29 23:44:52 UTC
Created attachment 49661 [details] [review] Bug 16162: Making dictionary 'Delete' a button To test: 1) Go to Reports -> View dictionary 2) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 3) Confirm that the button does not wrap on narrower browsers. 4) Confirm that column heading is now 'Action'. 5) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt FAIL forbidden patterns forbidden pattern: tab char (line 82) forbidden pattern: tab char (line 71) forbidden pattern: tab char (line 79) Created attachment 49713 [details] [review] Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs To test: 1) Go to Reports -> View dictionary 2) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 3) Confirm that the button does not wrap on narrower browsers. 4) Confirm that column heading is now 'Action'. 5) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Created attachment 49715 [details] [review] Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs To test: 1) Go to Reports -> View dictionary 2) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 3) Confirm that the button does not wrap on narrower browsers. 4) Confirm that column heading is now 'Action'. 5) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Aleisha, please submit a followup on top of bug 16161 Created attachment 49748 [details] [review] Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs EDIT2: Will now apply with patch on Bug 16161 To test: 1) Apply Bug 16161 first 2) Go to Reports -> View dictionary 3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 4) Confirm that the button does not wrap on narrower browsers. 5) Confirm that column heading is now 'Action'. 6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49816 [details] [review] Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs EDIT2: Will now apply with patch on Bug 16161 To test: 1) Apply Bug 16161 first 2) Go to Reports -> View dictionary 3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 4) Confirm that the button does not wrap on narrower browsers. 5) Confirm that column heading is now 'Action'. 6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Tested on top of Bug 16161 Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49819 [details] [review] [PASSED QA] Bug 16162: Making dictionary 'Delete' a button EDIT: This patch should have gotten rid of those tabs EDIT2: Will now apply with patch on Bug 16161 To test: 1) Apply Bug 16161 first 2) Go to Reports -> View dictionary 3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button. 4) Confirm that the button does not wrap on narrower browsers. 5) Confirm that column heading is now 'Action'. 6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.) Sponsored-by: Catalyst IT Tested on top of Bug 16161 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 release. Thanks! |