|
Description
Tomás Cohen Arazi (tcohen)
2016-03-30 18:14:28 UTC
Created attachment 49692 [details] [review] Bug 16174: Warning in tt_valid.t due to bug 15527 Bug 15527 introduced a new directory (xslt) on the top level OPAC templates directory. The tt_valid.t script should include that top level dir on the list of excluded dirs so it doesn't look for themes there. To test: - Run $ prove xt/tt_valid.t => FAIL: You get the following warning: Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory at xt/tt_valid.t line 8 - Apply the patch - Run $ prove xt/tt_valid.t => SUCCESS: Tests pass and don't raise warnings. Created attachment 49693 [details] [review] Bug 16174: icondirectories.t broken due to bug 15527 This patch fixes it. To test: - Run $ prove xt/author/icondirectories.t => FAIL: Tests fail: Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists' - Apply the patch - Run $ prove xt/author/icondirectories.t => SUCCESS: Tests pass and don't raise warnings. - Sign off Created attachment 49702 [details] [review] Bug 16174: Warning in tt_valid.t due to bug 15527 Bug 15527 introduced a new directory (xslt) on the top level OPAC templates directory. The tt_valid.t script should include that top level dir on the list of excluded dirs so it doesn't look for themes there. To test: - Run $ prove xt/tt_valid.t => FAIL: You get the following warning: Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory at xt/tt_valid.t line 8 - Apply the patch - Run $ prove xt/tt_valid.t => SUCCESS: Tests pass and don't raise warnings. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 49703 [details] [review] Bug 16174: icondirectories.t broken due to bug 15527 This patch fixes it. To test: - Run $ prove xt/author/icondirectories.t => FAIL: Tests fail: Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists' - Apply the patch - Run $ prove xt/author/icondirectories.t => SUCCESS: Tests pass and don't raise warnings. - Sign off Signed-off-by: Mark Tompsett <mtompset@hotmail.com> There are some more:
git grep readdir|grep lib|grep js|grep -v xslt
xt/author/icondirectories.t:my @staff_themes = grep { not /^\.|lib|js/ } readdir($dh);
xt/author/translatable-templates.t:my @opac_themes = grep { not /^\.|lib|js/ } readdir($dh);
xt/author/translatable-templates.t:my @staff_themes = grep { not /^\.|lib|js/ } readdir($dh);
xt/author/valid-templates.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
xt/author/valid-templates.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
xt/single_quotes.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
xt/single_quotes.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
xt/tt_valid.t:for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
Not the ones for the staff interface.
Created attachment 49737 [details] [review] Bug 16174: (QA followup) Fix remaining tests Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Created attachment 49757 [details] [review] Bug 16174: (QA followup) Fix remaining tests Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 49777 [details] [review] Bug 16174: Warning in tt_valid.t due to bug 15527 Bug 15527 introduced a new directory (xslt) on the top level OPAC templates directory. The tt_valid.t script should include that top level dir on the list of excluded dirs so it doesn't look for themes there. To test: - Run $ prove xt/tt_valid.t => FAIL: You get the following warning: Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory at xt/tt_valid.t line 8 - Apply the patch - Run $ prove xt/tt_valid.t => SUCCESS: Tests pass and don't raise warnings. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 49778 [details] [review] Bug 16174: icondirectories.t broken due to bug 15527 This patch fixes it. To test: - Run $ prove xt/author/icondirectories.t => FAIL: Tests fail: Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists' - Apply the patch - Run $ prove xt/author/icondirectories.t => SUCCESS: Tests pass and don't raise warnings. - Sign off Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 49779 [details] [review] Bug 16174: (QA followup) Fix remaining tests Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to Master - Should be in the May 2016 release. Thanks! Not needed in stable versions, status changed to RESOLVED |