Bug 16186

Summary: t/db_dependent/Circulation_Issuingrule.t is failing
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: CirculationAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: brendan, gmcharlt, julian.maurice, kyle.m.hall, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing

Description Mark Tompsett 2016-04-01 14:18:56 UTC
Bug 5786 changed the query for GetIssuingRules to SELECT *, which means if columns are added to the DB, this breaks.

Add missing column(s) into the issuing rules hashes in the test.
Comment 1 Mark Tompsett 2016-04-01 14:38:59 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi (tcohen) 2016-04-01 15:11:52 UTC
Created attachment 49796 [details] [review]
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing

TEST PLAN
---------
1) prove t/db_dependent/Circulation_Issuingrule.t
   -- fails
2) apply patch
3) prove t/db_dependent/Circulation_Issuingrule.t
   -- pass
4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t
   -- notice that bug 5876 and bug 9129 combined to cause this
5) run koha qa test tools

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Comment 3 Tomás Cohen Arazi (tcohen) 2016-04-01 15:13:07 UTC
Trivial fix for the tests.
Comment 4 Brendan Gallagher 2016-04-01 18:46:13 UTC
Pushed to Master - Should be in the 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-06 13:23:32 UTC
Not needed in stable versions, status changed to RESOLVED