Bug 16191

Summary: t/Ris.t is noisy
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: Test SuiteAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: minor    
Priority: P5 - low CC: brendan, f.demians, jonathan.druart, julian.maurice, veron
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 16199    
Attachments: Bug 16191: t/Ris.t is noisy
Bug 16191: t/Ris.t is noisy
Bug 16191: t/Ris.t is noisy

Description Mark Tompsett 2016-04-01 21:57:57 UTC
While running a "prove -r t", I noticed again t/Ris.t is noisy.
Fixing most of the issues are relatively easy.
However, Jonathan suggests that I open a new bug as a result of commenting on this particular issue (see bug 12357).
Comment 1 Mark Tompsett 2016-04-01 22:02:33 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-02 07:07:15 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-04-04 10:43:24 UTC
(In reply to M. Tompsett from comment #1)
> 3) prove t/Ris.t
>    -- just one confusing noise.

Why did not you remove it?
Comment 4 Mark Tompsett 2016-04-04 14:34:11 UTC
(In reply to Jonathan Druart from comment #3)
> (In reply to M. Tompsett from comment #1)
> > 3) prove t/Ris.t
> >    -- just one confusing noise.
> 
> Why did not you remove it?

Because I did not feel comfortable deciding that particular fix.
Comment 5 Jonathan Druart 2016-04-05 06:52:35 UTC
Created attachment 49894 [details] [review]
Bug 16191: t/Ris.t is noisy

TEST PLAN
---------
1) prove t/Ris.t
   -- very noisy
2) apply patch
3) prove t/Ris.t
   -- just one confusing noise.
4) run koha qa test tools

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2016-04-05 06:56:03 UTC
(In reply to M. Tompsett from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > (In reply to M. Tompsett from comment #1)
> > > 3) prove t/Ris.t
> > >    -- just one confusing noise.
> > 
> > Why did not you remove it?
> 
> Because I did not feel comfortable deciding that particular fix.

See bug 16199.
Comment 7 Brendan Gallagher 2016-04-06 23:49:31 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 8 Julian Maurice 2016-04-08 07:17:19 UTC
Patch pushed to 3.22.x, will be in 3.22.6
Comment 9 Frédéric Demians 2016-04-27 15:33:51 UTC
Pushed to 3.22.x, will be in 3.20.11.