Bug 16194

Summary:	Do not consider xslt as valid theme dir in LangInstaller.pm
Product:	Koha	Reporter:	Bernardo Gonzalez Kriegel <bgkriegel>
Component:	I18N/L10N	Assignee:	Bernardo Gonzalez Kriegel <bgkriegel>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	brendan, f.demians, julian.maurice
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm [PASSED QA] Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm

Description Bernardo Gonzalez Kriegel 2016-04-04 13:51:58 UTC

Bug 15527 adds a new dir 'xslt' in opac-tmpl, and it's considered as a theme dir.

perl translate update es-ES
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.
/home/bgkriegel/kohaclone/koha-tmpl/opac-tmpl/xslt/en/: Input must be a directory.
(Symbolic links are not supported at the moment)
Try `/home/bgkriegel/kohaclone/misc/translator/tmpl_process3.pl --help for more information.

Comment 1 Bernardo Gonzalez Kriegel 2016-04-04 14:00:19 UTC Comment hidden (obsolete)

Created attachment 49860 [details] [review]
Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm

Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir.

To test:
1) Verify the problem on current master
Update translation for any lang, will see errors

2) Apply the patch

3) Update again, no errors

Comment 2 Tomás Cohen Arazi (tcohen) 2016-04-04 14:30:50 UTC Comment hidden (obsolete)

Created attachment 49862 [details] [review]
Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm

Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir.

To test:
1) Verify the problem on current master
Update translation for any lang, will see errors

2) Apply the patch

3) Update again, no errors

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected.

Comment 3 Katrin Fischer 2016-04-04 21:34:15 UTC

Created attachment 49881 [details] [review]
[PASSED QA] Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm

Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir.

To test:
1) Verify the problem on current master
Update translation for any lang, will see errors

2) Apply the patch

3) Update again, no errors

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Brendan Gallagher 2016-04-05 15:18:41 UTC

Pushed to Master - Should be in the May 2016 release.  Thanks!

Comment 5 Julian Maurice 2016-04-07 08:22:58 UTC

Not needed in stable versions, status changed to RESOLVED