| Summary: | Opac suggestions are broken if user is not logged in | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | brendan, jonathan.druart, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15629 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16198: Fix regression in OPAC suggestions
[SIGNED-OFF] Bug 16198: Fix regression in OPAC suggestions [PASSED QA] Bug 16198: Fix regression in OPAC suggestions |
||
|
Description
Katrin Fischer
2016-04-04 21:10:20 UTC
Copy and paste mistake, the error is: Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. Created attachment 49896 [details] [review] Bug 16198: Fix regression in OPAC suggestions Introduced by commit d564d3732d95455b4626dfa8ca711cd658003c17 Bug 15629: Koha::Libraries - Remove GetBranchInfo If the branchcodesuggestedby is not defined, the find won't return anything and ->branchname on an undefined value will raise Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. Test plan: -Staff Create a patron Use this patron to create a suggestion Delete the patron -OPAC Logout and trigger opac/opac-suggestions.pl Without this patch, you will get an error With this patch applied, everything should be ok Created attachment 49904 [details] [review] [SIGNED-OFF] Bug 16198: Fix regression in OPAC suggestions Introduced by commit d564d3732d95455b4626dfa8ca711cd658003c17 Bug 15629: Koha::Libraries - Remove GetBranchInfo If the branchcodesuggestedby is not defined, the find won't return anything and ->branchname on an undefined value will raise Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. Test plan: -Staff Create a patron Use this patron to create a suggestion Delete the patron -OPAC Logout and trigger opac/opac-suggestions.pl Without this patch, you will get an error With this patch applied, everything should be ok Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok following test plan No errors Created attachment 49933 [details] [review] [PASSED QA] Bug 16198: Fix regression in OPAC suggestions Introduced by commit d564d3732d95455b4626dfa8ca711cd658003c17 Bug 15629: Koha::Libraries - Remove GetBranchInfo If the branchcodesuggestedby is not defined, the find won't return anything and ->branchname on an undefined value will raise Can't call method "branchname" on an undefined value at /home/katrin/kohaclone/opac/opac-suggestions.pl line 153. Test plan: -Staff Create a patron Use this patron to create a suggestion Delete the patron -OPAC Logout and trigger opac/opac-suggestions.pl Without this patch, you will get an error With this patch applied, everything should be ok Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok following test plan No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks! Not needed in stable versions, status changed to RESOLVED |