| Summary: | Circulation_Branch.t doesn't set itemtype for test data | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | brendan, hector.hecaxmmx, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14598 | ||
| Attachments: |
Bug 16216: Circulation_Branch.t doesn't set itemtype for test data
[SIGNED-OFF]Bug 16216: Circulation_Branch.t doesn't set itemtype for test data [PASSED QA] Bug 16216: Circulation_Branch.t doesn't set itemtype for test data |
||
|
Description
Tomás Cohen Arazi (tcohen)
2016-04-06 15:43:45 UTC
Created attachment 49994 [details] [review] Bug 16216: Circulation_Branch.t doesn't set itemtype for test data This patch makes the tests create better data for them: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised - Apply the patch - Run $ prove t/db_dependent/Circulation_Branch.t => SUCCESS: No warnings raised - Sign off Created attachment 49995 [details] [review] [SIGNED-OFF]Bug 16216: Circulation_Branch.t doesn't set itemtype for test data This patch makes the tests create better data for them: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised - Apply the patch - Run $ prove t/db_dependent/Circulation_Branch.t => SUCCESS: No warnings raised - Sign off Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successful Created attachment 50009 [details] [review] [PASSED QA] Bug 16216: Circulation_Branch.t doesn't set itemtype for test data This patch makes the tests create better data for them: - Run $ prove t/db_dependent/Circulation_Branch.t => FAIL: Warnings raised - Apply the patch - Run $ prove t/db_dependent/Circulation_Branch.t => SUCCESS: No warnings raised - Sign off Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successful Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks! (more tests I love it) Why is this pushed if it depends on bug 14598 (which is Signed Off) ? Patch pushed to 3.22.x, will be in 3.22.8 |