Summary: | printfeercpt.tt (and others) does not include jQuery | ||
---|---|---|---|
Product: | Koha | Reporter: | Jesse Weaver <jweaver> |
Component: | Staff interface | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | gmcharlt, hector.hecaxmmx, julian.maurice, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16218: printfeercpt.tt (and others) does not include jQuery
[SIGNED-OFF]Bug 16218: printfeercpt.tt (and others) does not include jQuery [PASSED QA] Bug 16218: printfeercpt.tt (and others) does not include jQuery |
Description
Jesse Weaver
2016-04-06 20:34:58 UTC
Verified for: koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt Created attachment 50041 [details] [review] Bug 16218: printfeercpt.tt (and others) does not include jQuery This patch adds [% INCLUDE 'doc-head-close.inc' %] to the following files (to make them include jQuery): koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt To test: 1) Temporarily include the follwing lines in syspref IntranetSlipPrinterJS: function printThenClose() { if (typeof jQuery != 'undefined') { // jQuery is loaded => print the version alert(jQuery.fn.jquery); } else { alert('jQuery not available'); } } 2) Go to a users page and print slips: From the Print button in the tool bar: - Print summary - Print slip - Print quick slip From the "Fines" tab: Account - 'Print' link in the table with paid transactions Without patch, a JavaScript message 'jQuery not avaliable' appears. With patch, the message displays the current jQuery version (1.7.2) 3) Remove IntranetSlipPrinterJS - Verify that the slips above print as expected. Applies cleanly on top of (but does not depend of) Bug 15883. Created attachment 50535 [details] [review] [SIGNED-OFF]Bug 16218: printfeercpt.tt (and others) does not include jQuery This patch adds [% INCLUDE 'doc-head-close.inc' %] to the following files (to make them include jQuery): koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt To test: 1) Temporarily include the follwing lines in syspref IntranetSlipPrinterJS: function printThenClose() { if (typeof jQuery != 'undefined') { // jQuery is loaded => print the version alert(jQuery.fn.jquery); } else { alert('jQuery not available'); } } 2) Go to a users page and print slips: From the Print button in the tool bar: - Print summary - Print slip - Print quick slip From the "Fines" tab: Account - 'Print' link in the table with paid transactions Without patch, a JavaScript message 'jQuery not avaliable' appears. With patch, the message displays the current jQuery version (1.7.2) 3) Remove IntranetSlipPrinterJS - Verify that the slips above print as expected. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Created attachment 50621 [details] [review] [PASSED QA] Bug 16218: printfeercpt.tt (and others) does not include jQuery This patch adds [% INCLUDE 'doc-head-close.inc' %] to the following files (to make them include jQuery): koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt To test: 1) Temporarily include the follwing lines in syspref IntranetSlipPrinterJS: function printThenClose() { if (typeof jQuery != 'undefined') { // jQuery is loaded => print the version alert(jQuery.fn.jquery); } else { alert('jQuery not available'); } } 2) Go to a users page and print slips: From the Print button in the tool bar: - Print summary - Print slip - Print quick slip From the "Fines" tab: Account - 'Print' link in the table with paid transactions Without patch, a JavaScript message 'jQuery not avaliable' appears. With patch, the message displays the current jQuery version (1.7.2) 3) Remove IntranetSlipPrinterJS - Verify that the slips above print as expected. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for the 16.05 release. Tesekkür ederim Marc! Patch pushed to 3.22.x, will be in 3.22.7 |