| Summary: | Random failure for t/db_dependent/Reports_Guided.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Test Suite | Assignee: | Julian Maurice <julian.maurice> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | brendan, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 16224: Fix t/db_dependent/Reports_Guided.t
Bug 16224: Fix t/db_dependent/Reports_Guided.t [PASSED QA] Bug 16224: Fix t/db_dependent/Reports_Guided.t |
||
Created attachment 50031 [details] [review] Bug 16224: Fix t/db_dependent/Reports_Guided.t This test: is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1, "filter takes report id" ); can fail when $report_ids[0] is a substring of some saved_sql fields from other reports (reports that have a different id than $report_ids[0]). We can only be sure that get_saved_reports will return at least 1 report. Created attachment 50123 [details] [review] Bug 16224: Fix t/db_dependent/Reports_Guided.t This test: is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1, "filter takes report id" ); can fail when $report_ids[0] is a substring of some saved_sql fields from other reports (reports that have a different id than $report_ids[0]). We can only be sure that get_saved_reports will return at least 1 report. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Good catch Julian! Created attachment 50138 [details] [review] [PASSED QA] Bug 16224: Fix t/db_dependent/Reports_Guided.t This test: is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1, "filter takes report id" ); can fail when $report_ids[0] is a substring of some saved_sql fields from other reports (reports that have a different id than $report_ids[0]). We can only be sure that get_saved_reports will return at least 1 report. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.6 |
This test: is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1, "filter takes report id" ); can fail when $report_ids[0] is a substring of some saved_sql fields from other reports (reports that have a different id than $report_ids[0]). We can only be sure that get_saved_reports will return at least 1 report.