Summary: | Show tooltip with menu item when fund cannot be deleted | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P3 | CC: | brendan, fridolin.somers, gmcharlt, josef.moravec, julian.maurice, koha-bugs, magnus, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 2310 | ||
Attachments: |
Bug 16230 - Show tooltip with menu item when fund cannot be deleted
Bug 16230 - Show tooltip with menu item when fund cannot be deleted [PASSED QA] Bug 16230 - Show tooltip with menu item when fund cannot be deleted |
Description
Owen Leonard
2016-04-08 16:47:02 UTC
Created attachment 50088 [details] [review] Bug 16230 - Show tooltip with menu item when fund cannot be deleted This patch enables Bootstrap to generate a tooltip for the fund deletion menu item when a fund cannot be deleted because it has children. Also changed: Enable translation of the associated error message. To test you must have at least one fund which has a child fund. Apply the patch and go to Administration -> Funds. - In the list of funds, find a fund which has children. - Click the "Actions" menu. The "Delete" item should be disabled. - Hovering over the "Delete" item should display a Bootstrap-style tooltip with the explanation "This fund has children." - Clicking the "Delete" item should trigger an alert, "This fund has children. It cannot be deleted." - Clicking "Delete" on funds without children should work correctly. Created attachment 50108 [details] [review] Bug 16230 - Show tooltip with menu item when fund cannot be deleted This patch enables Bootstrap to generate a tooltip for the fund deletion menu item when a fund cannot be deleted because it has children. Also changed: Enable translation of the associated error message. To test you must have at least one fund which has a child fund. Apply the patch and go to Administration -> Funds. - In the list of funds, find a fund which has children. - Click the "Actions" menu. The "Delete" item should be disabled. - Hovering over the "Delete" item should display a Bootstrap-style tooltip with the explanation "This fund has children." - Clicking the "Delete" item should trigger an alert, "This fund has children. It cannot be deleted." - Clicking "Delete" on funds without children should work correctly. NOTE: Before tooltip shows in Chrome, but not bootstrap styling. After, bootstrap styled. The use of _() will add the ability to translate the alert(). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 50109 [details] [review] [PASSED QA] Bug 16230 - Show tooltip with menu item when fund cannot be deleted This patch enables Bootstrap to generate a tooltip for the fund deletion menu item when a fund cannot be deleted because it has children. Also changed: Enable translation of the associated error message. To test you must have at least one fund which has a child fund. Apply the patch and go to Administration -> Funds. - In the list of funds, find a fund which has children. - Click the "Actions" menu. The "Delete" item should be disabled. - Hovering over the "Delete" item should display a Bootstrap-style tooltip with the explanation "This fund has children." - Clicking the "Delete" item should trigger an alert, "This fund has children. It cannot be deleted." - Clicking "Delete" on funds without children should work correctly. NOTE: Before tooltip shows in Chrome, but not bootstrap styling. After, bootstrap styled. The use of _() will add the ability to translate the alert(). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.7 |