Summary: | Zebra-specific tests should pass with ES disabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 12478 | ||
Attachments: |
Bug 16249: Zebra-specific tests should pass with ES disabled
Bug 16249: Zebra-specific tests should pass with ES disabled [PASSED QA] Bug 16249: Zebra-specific tests should pass with ES disabled Bug 16469 - Remove the use of "onclick" from some catalog pages |
Description
Tomás Cohen Arazi (tcohen)
2016-04-12 18:28:13 UTC
Created attachment 50157 [details] [review] Bug 16249: Zebra-specific tests should pass with ES disabled This patch makes the t/db_dependent/Search.t tests correctly set 'Zebra' for the 'SearchEngine' syspref. To test: - On top of bug 12478 branch, run $ prove t/db_dependent/Search.t => FAIL: Tests fail - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: Tests now pass. Created attachment 50160 [details] [review] Bug 16249: Zebra-specific tests should pass with ES disabled This patch makes the t/db_dependent/Search.t tests correctly set 'Zebra' for the 'SearchEngine' syspref. To test: - On top of bug 12478 branch, run $ prove t/db_dependent/Search.t => FAIL: Tests fail - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: Tests now pass. Signed-off-by: Chris <chrisc@catalyst.net.nz> Created attachment 50762 [details] [review] [PASSED QA] Bug 16249: Zebra-specific tests should pass with ES disabled This patch makes the t/db_dependent/Search.t tests correctly set 'Zebra' for the 'SearchEngine' syspref. To test: - On top of bug 12478 branch, run $ prove t/db_dependent/Search.t => FAIL: Tests fail - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: Tests now pass. Signed-off-by: Chris <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to Master - Should be in the May 2016 Release. Thanks! Created attachment 51297 [details] [review] Bug 16469 - Remove the use of "onclick" from some catalog pages This patch removes the use of "onclick" attributes from two catalog-related templates: The local cover image viewer and the search results page. Events are now defined in JavaScript. To test: On the search results page: - Perform a catalog search which will return multiple results. - On the search results page, confirm that the "Select all" and "Clear all" links at the top of the results table work correctly. In the local cover image viewer: - The LocalCoverImages and AllowMultipleCovers system preferences must enabled, and at least one catalog record must have at least two local cover images attached. - Locate that record in the catalog and view the detail page for it. - Click the cover image in the "Images" tab to go to the image viewer page. - Clicking each local cover image thumnail should correctly display the larger version of each image. Comment on attachment 51297 [details] [review] Bug 16469 - Remove the use of "onclick" from some catalog pages Sorry, git-bz typo. Not needed in stable versions, status changed to RESOLVED |