Bug 16285

Summary: write_age() function throws error for patron categories that don't include dateofbirth in form
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: PatronsAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: brendan, gmcharlt, julian.maurice, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15206    
Bug Blocks:    
Attachments: Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form
Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form
[PASSED QA] Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form

Description Nick Clemens (kidclamp) 2016-04-18 16:07:12 UTC
To confirm:

Add a new patron fo type Library or School
Check js console and see "TypeError: document.form.dateofbirth is undefined"
Comment 1 Nick Clemens (kidclamp) 2016-04-18 17:18:26 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2016-04-19 01:46:21 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-19 06:21:10 UTC
Created attachment 50385 [details] [review]
[PASSED QA] Bug 16285 - write_age() function throws error for patron categories that don't include dateofbirth in form

To test:
1 Add a patron in category Library or School
2 Note the js error in the console
3 Apply patch
4 Repeat and note the error is gone

Signed-off-by: Chris Cormack <chrisc@catalyst.net.z>

Made it an explicit if, and fixed the author of the commit

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Brendan Gallagher 2016-04-20 18:37:39 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 5 Julian Maurice 2016-04-21 08:24:03 UTC
Not needed in stable versions, status changed to RESOLVED