| Summary: | Remove the use of "onclick" from transport cost matrix | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle, testopia, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/admin/transport-cost-matrix.pl | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 16305 - Remove the use of "onclick" from transport cost matrix
Bug 16305 - Remove the use of "onclick" from transport cost matrix [PASSED QA] Bug 16305 - Remove the use of "onclick" from transport cost matrix |
||
|
Description
Owen Leonard
2016-04-20 00:58:52 UTC
Created attachment 50450 [details] [review] Bug 16305 - Remove the use of "onclick" from transport cost matrix This patch updates the transport cost matrix template to eliminate the use of event attributes (onclick and onblur) in favor of JS separate from the markup. To test, apply the patch and go to Administration -> Transport cost matrix. - Click in any table cell. Form fields in the cell should activate. - Check and uncheck the "disable" checkbox. The form field should be correctly disabled and enabled. - Fill various enabled fields and submit the form to confirm that data is saved correctly. Created attachment 50455 [details] [review] Bug 16305 - Remove the use of "onclick" from transport cost matrix This patch updates the transport cost matrix template to eliminate the use of event attributes (onclick and onblur) in favor of JS separate from the markup. To test, apply the patch and go to Administration -> Transport cost matrix. - Click in any table cell. Form fields in the cell should activate. - Check and uncheck the "disable" checkbox. The form field should be correctly disabled and enabled. - Fill various enabled fields and submit the form to confirm that data is saved correctly. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 50624 [details] [review] [PASSED QA] Bug 16305 - Remove the use of "onclick" from transport cost matrix This patch updates the transport cost matrix template to eliminate the use of event attributes (onclick and onblur) in favor of JS separate from the markup. To test, apply the patch and go to Administration -> Transport cost matrix. - Click in any table cell. Form fields in the cell should activate. - Check and uncheck the "disable" checkbox. The form field should be correctly disabled and enabled. - Fill various enabled fields and submit the form to confirm that data is saved correctly. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for Koha 16.05. Thanks Owen! |