Bug 16310

Summary: Remove the use of "onclick" from audio alerts template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: f.demians, gmcharlt, kyle, testopia, veron
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/admin/audio_alerts.pl
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 16310 - Remove the use of "onclick" from audio alerts template
Bug 16310 - Remove the use of "onclick" from audio alerts template
[PASSED QA] Bug 16310 - Remove the use of "onclick" from audio alerts template

Description Owen Leonard 2016-04-20 14:27:48 UTC
There is one use of "onclick" in admin/audio_alerts.tt. It should be rewritten so that JS functionality can be separate from the markup.
Comment 1 Owen Leonard 2016-04-20 14:35:53 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-04-20 14:59:45 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-04-25 10:48:56 UTC
Created attachment 50627 [details] [review]
[PASSED QA] Bug 16310 - Remove the use of "onclick" from audio alerts template

This patch removes one use of "onclick" in favor of defining events in
the JavaScript.

This patch also makes changes to the style of some buttons to make the
interface a little more consistent with current practices.

To test, apply the patch and go to Administration -> Audio alerts.

- In the list of existing audio alerts, click the "Edit" button for any
  alert. The correct data should be loaded in the edit form.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Kyle M Hall (khall) 2016-04-29 15:46:07 UTC
Pushed to master for the 16.05 release. Thanks Owen!
Comment 5 Frédéric Demians 2016-08-05 06:06:10 UTC
Pushed in 16.05. Will be in 16.05.03.