|
Description
Tomás Cohen Arazi (tcohen)
2016-04-21 16:10:47 UTC
Created attachment 50531 [details] [review] Bug 16320: Refactor ILSDI_Services.t so it uses TestBuilder This patch refactors the tests so they are corerctly built using TestBuilder and wrapper inside a DB transaction in a less ambiguous way. To test: - Verify that the tests pass with the patch: - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Hi Tomás Test pass successful but give me this Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Is this Ok? Created attachment 50577 [details] [review] Bug 16320: Refactor ILSDI_Services.t so it uses TestBuilder This patch refactors the tests so they are corerctly built using TestBuilder and wrapper inside a DB transaction in a less ambiguous way. To test: - Verify that the tests pass with the patch: - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 50578 [details] [review] Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm Removes: Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Test plan: Run t/db_dependent/ILSDI_Services.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Héctor Eduardo Castro Avalos from comment #2) > Hi Tomás > > Test pass successful but give me this > Use of uninitialized value in string eq at > /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. > Use of uninitialized value in string eq at > /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. > Use of uninitialized value in string eq at > /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. > Use of uninitialized value in string eq at > /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. > > Is this Ok? Hector: Please add your signoff in order to get it thru QA. Thanks. PatronNotFount Created attachment 50579 [details] [review] Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm Removes: Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Test plan: Run t/db_dependent/ILSDI_Services.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 50587 [details] [review] [SIGNED-OFF]Bug 16320: Refactor ILSDI_Services.t so it uses TestBuilder This patch refactors the tests so they are corerctly built using TestBuilder and wrapper inside a DB transaction in a less ambiguous way. To test: - Verify that the tests pass with the patch: - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Created attachment 50588 [details] [review] [SIGNED-OFF]Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm Removes: Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399. Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423. Test plan: Run t/db_dependent/ILSDI_Services.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Thanks Hector and Tomas. Can pass QA now. @RM: This may go separately from 16155. Applies and passes both ways. Created attachment 50873 [details] [review] Bug 16320: [QA Follow-up] Fix borrower attribute test in ILSDI_Services Since bug 12267 removed the password option, this test should be adjusted. Test plan: Run the test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for the Koha 16.05 release. Thanks Tomas! |