| Summary: | 'Show all details' checkbox triggers JS error after jQuery upgrade | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | brendan, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/acqui/basket.pl?basketno=X | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15883 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade
Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade |
||
|
Description
Owen Leonard
2016-04-21 16:37:30 UTC
Created attachment 50532 [details] [review] Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes a problem with the 'Show all details' checkbox on the acquisitions basket page which prevented the checkbox from triggering the correct show/hide action on the table of orders. To test, apply the patch and go to Acquisitions. - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. Found two more instances of the same syntax. I will revise my patch to include them. Created attachment 50534 [details] [review] Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes problems with show/hide actions on a few pages caused by some problematic jQuery syntax. To test, apply the patch and go to Acquisitions. Testing basket.tt: - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. Testing invoice.tt: - Go to Acquisitions -> Invoices and perform an invoice search. - Click to view an invoice which includes one or more received records. - Click the 'Show all details' checkbox above the table of titles and confirm that it fuctions as described above. Testing newordersubscription.tt: - Go to Acquisitions and locate a vendor which is linked to a subscription - Create or add to a basket for that vendor. - Add an order using the 'From a subscription' option. - Perform a search for subscriptions. - In the table of subscriptions search results, checking or unchecking the "Show only renewed" checkbox should work correctly. Created attachment 50710 [details] [review] Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes problems with show/hide actions on a few pages caused by some problematic jQuery syntax. To test, apply the patch and go to Acquisitions. Testing basket.tt: - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. Testing invoice.tt: - Go to Acquisitions -> Invoices and perform an invoice search. - Click to view an invoice which includes one or more received records. - Click the 'Show all details' checkbox above the table of titles and confirm that it fuctions as described above. Testing newordersubscription.tt: - Go to Acquisitions and locate a vendor which is linked to a subscription - Create or add to a basket for that vendor. - Add an order using the 'From a subscription' option. - Perform a search for subscriptions. - In the table of subscriptions search results, checking or unchecking the "Show only renewed" checkbox should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 50730 [details] [review] Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes problems with show/hide actions on a few pages caused by some problematic jQuery syntax. To test, apply the patch and go to Acquisitions. Testing basket.tt: - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. Testing invoice.tt: - Go to Acquisitions -> Invoices and perform an invoice search. - Click to view an invoice which includes one or more received records. - Click the 'Show all details' checkbox above the table of titles and confirm that it fuctions as described above. Testing newordersubscription.tt: - Go to Acquisitions and locate a vendor which is linked to a subscription - Create or add to a basket for that vendor. - Add an order using the 'From a subscription' option. - Perform a search for subscriptions. - In the table of subscriptions search results, checking or unchecking the "Show only renewed" checkbox should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! It's not strictly needed in 3.22.x, but it works with jQuery 1.7.2 too, and improves code readability. Patch pushed to 3.22.x, will be in 3.22.7 |