Created attachment 50541 [details] [review] Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable This patch adds translatability for the tab "Unknown" in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt To test: - Apply patch - Examine koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt and verify that it handles the label "Unknown" (line 496) - Go to suggestion/suggestion.pl, set status of a suggestion to -- Choose a status -- and verify that the tab "Status unknown" appears - Bonus test: Go through a translation process and verify that "Status unknown" is translated Note: If you have a suggestion with unknown status, all suggestions are listed under this tab. This is not in the scope of this bug; this bug is about translation only. Created attachment 50543 [details] [review] Bug 16322 Translatability: "Unknown" in suggestion/suggestion.pl not translatable This patch adds translatability for the tab "Unknown" in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt To test: - Apply patch - Examine koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt and verify that it handles the label "Unknown" (line 496) - Go to suggestion/suggestion.pl, set status of a suggestion to -- Choose a status -- and verify that the tab "Status unknown" appears - Bonus test: Go through a translation process and verify that "Status unknown" is translated Note: If you have a suggestion with unknown status, all suggestions are listed under this tab. This is not in the scope of this bug; this bug is about translation only. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Created attachment 50544 [details] [review] Bug 16322: Translatability: Also adding "Status unknown" to column table Also add the "Status unknown to the column table To test: follow previous commit Hi Marc I changed the status unknown in the column table too. Feel free to obsolete the last patch if you don't like the idea. No Biggie. (In reply to Héctor Eduardo Castro Avalos from comment #4) > Hi Marc > > I changed the status unknown in the column table too. > > Feel free to obsolete the last patch if you don't like the idea. No Biggie. Hi Héctor, thanks for catching. I will sign off on your patch. Created attachment 50560 [details] [review] Bug 16322: Translatability: Also adding "Status unknown" to column table Also add the "Status unknown to the column table To test: follow previous commit Signed-off-by: Marc Véron <veron@veron.ch> (In reply to Marc Véron from comment #1) (...) > Note: If you have a suggestion with unknown status, all suggestions are > listed under this tab. This is not in the scope of this bug; this bug is > about translation only. (...) See Bug 16325 Created attachment 50575 [details] [review] Bug 16322 - Translatability: "Unknown" in suggestion/suggestion.pl not translatable This patch adds translatability for the tab "Unknown" in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt To test: - Apply patch - Examine koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt and verify that it handles the label "Unknown" (line 496) - Go to suggestion/suggestion.pl, set status of a suggestion to -- Choose a status -- and verify that the tab "Status unknown" appears - Bonus test: Go through a translation process and verify that "Status unknown" is translated Note: If you have a suggestion with unknown status, all suggestions are listed under this tab. This is not in the scope of this bug; this bug is about translation only. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as expected Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 50576 [details] [review] Bug 16322: Translatability: Also adding "Status unknown" to column table Also add the "Status unknown to the column table To test: follow previous commit Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for the 16.05 release. Thanks Marc! Patch pushed to 3.22.x, will be in 3.22.7 |
See suggestion/suggestion.pl line 59: return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown";