Summary: | UX of holds patron search with long lists of results | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, brendan, f.demians, gmcharlt, jonathan.druart, julian.maurice, kyle.m.hall, liz, magnus, mirko, nick, testopia, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15793 | ||
Bug Blocks: | 16334, 16462, 16596 | ||
Attachments: |
Bug 16336 - UX of holds patron search with long lists of results
Bug 16336 [Revised] UX of holds patron search with long lists of results [SIGNED-OFF] Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 16336 [Revised] UX of holds patron search with long lists of results |
Description
Owen Leonard
2016-04-25 13:29:56 UTC
Created attachment 51292 [details] [review] Bug 16336 - UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Created attachment 51586 [details] [review] Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. Created attachment 51731 [details] [review] [SIGNED-OFF] Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 51748 [details] [review] Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Lot of inconsistencies are fixed by this patch, well done Owen. I am wondering why branchcode and categorycode are displayed, instead of their description, on these 2 tables. Any valid reasons? (In reply to Jonathan Druart from comment #5) > I am wondering why branchcode and categorycode are displayed, instead of > their description, on these 2 tables. Any valid reasons? It is probably simply a remnant of the old version which displayed the list in a <select> and required a more compact display. (In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #5) > > > I am wondering why branchcode and categorycode are displayed, instead of > > their description, on these 2 tables. Any valid reasons? > > It is probably simply a remnant of the old version which displayed the list > in a <select> and required a more compact display. A patch is going to be submitted on bug 16336. Pushed to Master - Should be in the November 2016 Release. Thanks Pushed in 16.05. Will be in 16.05.01. (In reply to Jonathan Druart from comment #7) > A patch is going to be submitted on bug 16336. Read bug 16596. |