| Summary: | Use floating toolbar on advanced search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Searching | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16398 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16363: Add floating toolbar to advanced search
This is how it should look showing fewer options Bug 16363: Add floating toolbar to advanced search [SIGNED-OFF] Bug 16363: Add floating toolbar to advanced search [PASSED QA] Bug 16363: Add floating toolbar to advanced search |
||
|
Description
Aleisha Amohia
2016-04-27 04:05:57 UTC
Created attachment 50784 [details] [review] Bug 16363: Add floating toolbar to advanced search To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT I like the look of the toolbar. I'm not sure about the change from "new search" to "clear fields." I'd like to hear more opinions on that. I would like to see one minor change: Toolbar buttons should use "btn-small" instead of "btn-mini." Created attachment 50847 [details]
This is how it should look showing fewer options
Comment on attachment 50847 [details]
This is how it should look showing fewer options
Sorry, wrong bug
Created attachment 50849 [details] [review] Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT Created attachment 50857 [details] [review] [SIGNED-OFF] Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 50891 [details] [review] [PASSED QA] Bug 16363: Add floating toolbar to advanced search EDIT: Ah yes I was so sure it wasn't mini but couldn't remember what to use! Thanks for that Owen To test: 1) Go to advanced search 2) Confirm Save, More Options and Clear fields (notice change from New search to Clear fields) are in toolbar and work as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I like it! Pushed to master! Should be in the May 2016 release! Shukran Aleisha! Just found a bug, to reproduce: - Click on more options - you get /catalogue/search.pl?expanded_options=1 - Click on "Clear fields" - you get /catalogue/search.pl?do=Clear => You have lost the expanded_options flag (In reply to Jonathan Druart from comment #10) > => You have lost the expanded_options flag As far as I can tell this bug existed before the changes made by this patch. I can reproduce it in our 3.18.x catalog. (In reply to Owen Leonard from comment #11) > (In reply to Jonathan Druart from comment #10) > > => You have lost the expanded_options flag > > As far as I can tell this bug existed before the changes made by this patch. > I can reproduce it in our 3.18.x catalog. Indeed! I have opened bug 16398. Confused - I don't see the floating toolbar in master? Never mind - a problem with my branch not being as current as I had thought. |