Summary: | Replace the use of "onclick" for deletion confirmation in some templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Arslan Farooq <arslanone> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | arslanone, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 16058 | ||
Bug Blocks: | 16386 | ||
Attachments: |
Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates
Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates [PASSED QA] Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates |
Description
Owen Leonard
2016-04-27 16:30:09 UTC
Created attachment 50832 [details] [review] Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates This patch removes the use of event attributes from several templates where the attributes were used to handle deletion operations. I've grouped these changes in one patch because each template had only small changes to be made. Unrelated change: Reformatted the "no news items" message which is displayed if there are no news items. To test, apply the patch and test deletion operations on the following pages. Clicking "delete" should prompty you to confirm. Test both the confirm and cancel actions. - On the staff client home page, test deletion of a news item. - On the patron lists page, test deletion of a patron list. - In the patron card creator, choose Manage -> Images. Test the "Delete" button for a single image. - On the news page, test deletion of a single news item. - On the news page, test deletion of multiple items. Created attachment 50871 [details] [review] Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates This patch removes the use of event attributes from several templates where the attributes were used to handle deletion operations. I've grouped these changes in one patch because each template had only small changes to be made. Unrelated change: Reformatted the "no news items" message which is displayed if there are no news items. To test, apply the patch and test deletion operations on the following pages. Clicking "delete" should prompty you to confirm. Test both the confirm and cancel actions. - On the staff client home page, test deletion of a news item. - On the patron lists page, test deletion of a patron list. - In the patron card creator, choose Manage -> Images. Test the "Delete" button for a single image. - On the news page, test deletion of a single news item. - On the news page, test deletion of multiple items. ----------------------------------------------------- All things were tested and everything worked OK. Did QA tools as well, and it passed. However, there was that Plugins.pm message again "Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206." ----------------------------------------------------- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt OK forbidden patterns SKIP spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Koha.pm aborted. Compilation failed in require at /usr/local/lib/perl/5.14.2/Template/Plugins.pm line 206. OK koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt OK forbidden patterns SKIP spelling OK tt_valid OK valid_template ----------------------------------------------------- Created attachment 50887 [details] [review] [PASSED QA] Bug 16372 - Replace the use of "onclick" for deletion confirmation in some templates This patch removes the use of event attributes from several templates where the attributes were used to handle deletion operations. I've grouped these changes in one patch because each template had only small changes to be made. Unrelated change: Reformatted the "no news items" message which is displayed if there are no news items. To test, apply the patch and test deletion operations on the following pages. Clicking "delete" should prompty you to confirm. Test both the confirm and cancel actions. - On the staff client home page, test deletion of a news item. - On the patron lists page, test deletion of a patron list. - In the patron card creator, choose Manage -> Images. Test the "Delete" button for a single image. - On the news page, test deletion of a single news item. - On the news page, test deletion of multiple items. Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for the 16.05 release. Thanks Owen! |