Summary: | merge.pl reports success but files are not merged | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Cataloging | Assignee: | Jacek Ablewicz <abl> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P3 | CC: | abl, brendan, julian.maurice, katrin.fischer, m.de.rooy, marjorie.barry-vila |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16373: merge.pl reports success but files are not merged
Bug 16373: merge.pl reports success but files are not merged [PASSED QA] Bug 16373: merge.pl reports success but files are not merged |
Description
Nick Clemens (kidclamp)
2016-04-27 22:54:01 UTC
Can confirm this is broken again on master. Created attachment 50876 [details] [review] Bug 16373: merge.pl reports success but files are not merged To recreate: 1) Select two biblios to merge 2) Merge them 3) Sucess reported but list of bibs contains only the reference record. 4) View the 'new' record, it won't have any additional items 5) View the 'merged' record, it is still there with its items This happens because record IDs (biblionumbers) are not correctly set up in the template on the 2nd merge stage, since Bug 15358. To test: 1) apply patch 2) try to recreate this issue once again, confirm that a problem is resolved Created attachment 50880 [details] [review] Bug 16373: merge.pl reports success but files are not merged To recreate: 1) Select two biblios to merge 2) Merge them 3) Sucess reported but list of bibs contains only the reference record. 4) View the 'new' record, it won't have any additional items 5) View the 'merged' record, it is still there with its items This happens because record IDs (biblionumbers) are not correctly set up in the template on the 2nd merge stage, since Bug 15358. To test: 1) apply patch 2) try to recreate this issue once again, confirm that a problem is resolved Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Looking at this! Created attachment 50886 [details] [review] [PASSED QA] Bug 16373: merge.pl reports success but files are not merged To recreate: 1) Select two biblios to merge 2) Merge them 3) Sucess reported but list of bibs contains only the reference record. 4) View the 'new' record, it won't have any additional items 5) View the 'merged' record, it is still there with its items This happens because record IDs (biblionumbers) are not correctly set up in the template on the 2nd merge stage, since Bug 15358. To test: 1) apply patch 2) try to recreate this issue once again, confirm that a problem is resolved Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Jacek, thx a lot for the quick fix! Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.7 |