| Summary: | Fix formatting of review.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marc Véron <veron> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16238, 16241, 16381 | ||
| Bug Blocks: | |||
|
Description
Marc Véron
2016-04-29 09:16:49 UTC
The staff client templates are full of tab characters, so I don't think we should file bugs for each one. My understanding of the general practice regarding indentation is: - Always remove tab characters from lines which are changed by your patches. - If you want to make other changes to whitespace or indentation, submit a separate patch. Submitting whitespace fixes is always going to create merge problems for pending patches, so we should check http://splitter.koha-community.org for pending patches. It would be interesting if the splitter tool could show a list of templates which have /no/ patches in the queue. Those would be great candidates for whitespace fix patches. Owen is right stating that we decided a while ago not to clean files globally to avoid conflicts. Tab cleaning is a bit less difficult than perltidy, as it does keep the lines the same and you can use -w to not see whitespace changes. |