Summary: | Fix Holds.t (tests 9 and 39) | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | julian.maurice, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16403: Fix holds.t (tests 9 and 39)
Bug 16403: Fix holds.t (tests 9 and 39) Bug 16403: Fix holds.t (tests 9 and 39) Bug 16403: Remove unnecessary undef param |
Description
Marcel de Rooy
2016-04-30 12:41:30 UTC
Created attachment 51050 [details] [review] Bug 16403: Fix holds.t (tests 9 and 39) Resolves this: Failed test 'GetReservesFromItemnumber should return a valid borrowernumber' at t/db_dependent/Holds.t line 97. got: '2000001890' expected: '2000001889' Failed test 'Test AlterPriority(), move to bottom' at t/db_dependent/Holds.t line 220. got: '4' expected: '5' Test plan: Run the test before and after applying this patch. Created attachment 51054 [details] [review] Bug 16403: Fix holds.t (tests 9 and 39) Resolves this: Failed test 'GetReservesFromItemnumber should return a valid borrowernumber' at t/db_dependent/Holds.t line 97. got: '2000001890' expected: '2000001889' Failed test 'Test AlterPriority(), move to bottom' at t/db_dependent/Holds.t line 220. got: '4' expected: '5' Test plan: Run the test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch> (In reply to Marc Véron from comment #2) > Signed-off-by: Marc Véron <veron@veron.ch> Thx Marc for this fast signoff Created attachment 51073 [details] [review] Bug 16403: Fix holds.t (tests 9 and 39) Resolves this: Failed test 'GetReservesFromItemnumber should return a valid borrowernumber' at t/db_dependent/Holds.t line 97. got: '2000001890' expected: '2000001889' Failed test 'Test AlterPriority(), move to bottom' at t/db_dependent/Holds.t line 220. got: '4' expected: '5' Test plan: Run the test before and after applying this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 51074 [details] [review] Bug 16403: Remove unnecessary undef param Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #5) > Created attachment 51074 [details] [review] [review] > Bug 16403: Remove unnecessary undef param > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I explicitly added the undef to *show* that the date is not defined Pushed to master for Koha 16.05. Thanks Marcel and Jonathan! Not needed in stable versions, status changed to RESOLVED |