Bug 16405

Summary: Fix Circulation/NoIssuesChargeGuarantees.t test 2
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, julian.maurice, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14577    
Bug Blocks:    
Attachments: Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2
[SIGNED-OFF] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2
[ALTERNATIVE-PATCH] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2

Description Marcel de Rooy 2016-04-30 13:02:27 UTC
Resolve:
#   Failed test 'Patron cannot check out item due to debt for guarantee'
#   at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63.
#          got: '10'
#     expected: '10.00'
Comment 1 Marcel de Rooy 2016-04-30 13:04:02 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2016-04-30 16:02:42 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2016-05-02 07:01:34 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Thx for your signoffs, Bernardo.
Comment 4 Jonathan Druart 2016-05-02 09:41:20 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-05-02 09:41:57 UTC
Marcel, I think it's better to keep `is`, could you have a look at my alternative patch please?
Comment 6 Marcel de Rooy 2016-05-02 10:11:13 UTC Comment hidden (obsolete)
Comment 7 Marcel de Rooy 2016-05-02 10:14:24 UTC
No problem.

is( $issuingimpossible->{DEBT_GUARANTEES} == 10.00 , 1, '')
and 
is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, '')

look the same to me btw
Comment 8 Tomás Cohen Arazi 2016-05-02 19:18:10 UTC
Created attachment 51113 [details] [review]
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2

Resolves:
Failed test 'Patron cannot check out item due to debt for guarantee'
at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63.
          got: '10'
     expected: '10.00'

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Kyle M Hall 2016-05-04 14:24:10 UTC
Pushed to master for Koha 16.05, thanks Jonathan!
Comment 10 Julian Maurice 2016-05-16 08:59:33 UTC
Not needed in stable versions, status changed to RESOLVED