Summary: | Fix Circulation/NoIssuesChargeGuarantees.t test 2 | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 14577 | ||
Bug Blocks: | |||
Attachments: |
Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2
[SIGNED-OFF] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 [ALTERNATIVE-PATCH] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 |
Description
Marcel de Rooy
2016-04-30 13:02:27 UTC
Created attachment 51053 [details] [review] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Created attachment 51061 [details] [review] [SIGNED-OFF] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test pass, no errors. (In reply to Bernardo Gonzalez Kriegel from comment #2) > Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Thx for your signoffs, Bernardo. Created attachment 51076 [details] [review] [ALTERNATIVE-PATCH] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Marcel, I think it's better to keep `is`, could you have a look at my alternative patch please? Created attachment 51079 [details] [review] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> No problem. is( $issuingimpossible->{DEBT_GUARANTEES} == 10.00 , 1, '') and is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, '') look the same to me btw Created attachment 51113 [details] [review] Bug 16405: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Resolves: Failed test 'Patron cannot check out item due to debt for guarantee' at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. got: '10' expected: '10.00' Test plan: Run the test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for Koha 16.05, thanks Jonathan! Not needed in stable versions, status changed to RESOLVED |