Summary: | Layout problem on staff client detail page if local cover images are enabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, julian.maurice, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/catalogue/detail.pl?biblionumber=X | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Screenshot showing layout problem
Bug 16415 - Layout problem on staff client detail page if local cover images are enabled Bug 16415 - Layout problem on staff client detail page if local cover images are enabled Bug 16415 - Layout problem on staff client detail page if local cover images are enabled |
Created attachment 51103 [details] [review] Bug 16415 - Layout problem on staff client detail page if local cover images are enabled This patch fixes a layout problem which appears on the staff client bibliographic detail page if local covers are enabled but Amazon covers are not. To test, apply the patch and turn off AmazonCoverImages. - Enable the LocalCoverImages system preference and locate or create a record which has a local cover image associated with it. - View the bibliographic detail page. The bibliographic details should display in two columns, with text on the left and local cover image on the right. - Test with AmazonCoverImages and LocalCoverImages enabled. - Test with AmazonCoverImages enabled and LocalCoverImages disabled. Created attachment 51109 [details] [review] Bug 16415 - Layout problem on staff client detail page if local cover images are enabled This patch fixes a layout problem which appears on the staff client bibliographic detail page if local covers are enabled but Amazon covers are not. To test, apply the patch and turn off AmazonCoverImages. - Enable the LocalCoverImages system preference and locate or create a record which has a local cover image associated with it. - View the bibliographic detail page. The bibliographic details should display in two columns, with text on the left and local cover image on the right. - Test with AmazonCoverImages and LocalCoverImages enabled. - Test with AmazonCoverImages enabled and LocalCoverImages disabled. All combinations are OK. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 51209 [details] [review] Bug 16415 - Layout problem on staff client detail page if local cover images are enabled This patch fixes a layout problem which appears on the staff client bibliographic detail page if local covers are enabled but Amazon covers are not. To test, apply the patch and turn off AmazonCoverImages. - Enable the LocalCoverImages system preference and locate or create a record which has a local cover image associated with it. - View the bibliographic detail page. The bibliographic details should display in two columns, with text on the left and local cover image on the right. - Test with AmazonCoverImages and LocalCoverImages enabled. - Test with AmazonCoverImages enabled and LocalCoverImages disabled. All combinations are OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.7 |
Created attachment 51102 [details] Screenshot showing layout problem If you have local cover images enabled in the staff client but not Amazon images, local covers are not displayed in a column on the right like they should be.