Description
verolencinas
2016-05-02 21:25:37 UTC
Created attachment 78977 [details] [review] Bug 16424: Add framework support to advanced MARC editor Keeps the selected framework, allows selecting another and validates the record using the correct framework. Contains additional minor tweaks to display proper error messages. To test: 1. Add a record with a non-default framework in the basic editor. 2. Switch to advanced editor and make sure the settings menu displays the correct framework. 3. Save the record and confirm that the framework code did not change. 4. Change the framework and save the record again. 5. Verify that the framework code changed. 6. Change one framework to make an extra field mandatory. 7. Make sure that the field is required in the editor when the framework above is selected but not when another framework is selected. Created attachment 78978 [details] [review] Bug 16424: Make the svc/bib service keep the existing framework code Previously the framework code would have been reset when the record was saved, but that seems to have been a mistake. The first patch contains the actual functionality. The second one is not necessary for this to work, but fixes the issue that was an apparent bug in the service. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Ere, changes to .css should not be committed to avoid such conflicts. It may be better to have a step to the test plan to remind testers to regenerate it. If you want it to be testable in a sandbox you can provide the css changes on a separate patch (to ease rebase and QA) Created attachment 79009 [details] [review] Bug 16424: Add framework support to advanced MARC editor Keeps the selected framework, allows selecting another and validates the record using the correct framework. Contains additional minor tweaks to display proper error messages. To test: 1. Add a record with a non-default framework in the basic editor. 2. Switch to advanced editor and make sure the settings menu displays the correct framework. 3. Save the record and confirm that the framework code did not change. 4. Change the framework and save the record again. 5. Verify that the framework code changed. 6. Change one framework to make an extra field mandatory. 7. Make sure that the field is required in the editor when the framework above is selected but not when another framework is selected. Created attachment 79010 [details] [review] Bug 16424: Minor CSS change for the advanced editor Settings menu Created attachment 79011 [details] [review] Bug 16424: Make the svc/bib service keep the existing framework code Previously the framework code would have been reset when the record was saved, but that seems to have been a mistake. Ok, moved the css change to a separate patch. Please remember to regenerate css when testing to make the settings menu in the advanced editor look good. Created attachment 79017 [details] [review] Bug 16424: Handle framework code properly also when adding a new record Created attachment 79022 [details] [review] Bug 16424: Update default values in advanced editor when changing frameworks. Hi Ere, I'm testing this patch. But at point 7. Make sure that the field is required in the editor when the framework above is selected but not when another framework is selected I don't see any changes. Short video is more than thousands words: http://recordit.co/qAwNt4BQtd Is necessary to save record between change of framework? Thank You Mike Hi Michal, Thanks for testing. Validation is only done when the record is saved, so you won't see notification about missing fields until you try to save the record. If you are able to save the record without errors after selecting a framework that requires a field that the record does not contain, there's an error. I couldn't tell from the video since I don't know for sure which fields are required in the frameworks you used. Ere, thank You for explanation. I tried ot again and Rancor works as You describe. Good work. Mike Created attachment 79294 [details] [review] Bug 16424: Add framework support to advanced MARC editor Keeps the selected framework, allows selecting another and validates the record using the correct framework. Contains additional minor tweaks to display proper error messages. To test: 1. Add a record with a non-default framework in the basic editor. 2. Switch to advanced editor and make sure the settings menu displays the correct framework. 3. Save the record and confirm that the framework code did not change. 4. Change the framework and save the record again. 5. Verify that the framework code changed. 6. Change one framework to make an extra field mandatory. 7. Make sure that the field is required in the editor when the framework above is selected but not when another framework is selected. Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 79295 [details] [review] Bug 16424: Minor CSS change for the advanced editor Settings menu Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Your Full Name <your_email> Created attachment 79296 [details] [review] Bug 16424: Make the svc/bib service keep the existing framework code Previously the framework code would have been reset when the record was saved, but that seems to have been a mistake. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Your Full Name <your_email> Created attachment 79297 [details] [review] Bug 16424: Handle framework code properly also when adding a new record Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Your Full Name <your_email> Created attachment 79298 [details] [review] Bug 16424: Update default values in advanced editor when changing frameworks. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Your Full Name <your_email> Created attachment 79499 [details] [review] Bug 16424: Add framework support to advanced MARC editor Keeps the selected framework, allows selecting another and validates the record using the correct framework. Contains additional minor tweaks to display proper error messages. To test: 1. Add a record with a non-default framework in the basic editor. 2. Switch to advanced editor and make sure the settings menu displays the correct framework. 3. Save the record and confirm that the framework code did not change. 4. Change the framework and save the record again. 5. Verify that the framework code changed. 6. Change one framework to make an extra field mandatory. 7. Make sure that the field is required in the editor when the framework above is selected but not when another framework is selected. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79500 [details] [review] Bug 16424: Minor CSS change for the advanced editor Settings menu Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79501 [details] [review] Bug 16424: Make the svc/bib service keep the existing framework code Previously the framework code would have been reset when the record was saved, but that seems to have been a mistake. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79502 [details] [review] Bug 16424: Handle framework code properly also when adding a new record Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79503 [details] [review] Bug 16424: Update default values in advanced editor when changing frameworks. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79504 [details] [review] Bug 16424: (QA follow-up) Use Modern::Perl Awesome work all! Pushed to master for 18.11 Copyright is wrong in svc/bib_framework Created attachment 79621 [details] [review] Bug 16424: (follow-up) remove wrong copyright statements Marking this as an enhancement as although I do agree it's an important issue to be resolved, it would be an unexpected change for existing users on the stable branches. |