Bug 16427

I think this wasn't implemented for the staff side in the past - I have taken a look recently as one of our libraries has also asked for this (3.18). One problem is that there is no 'nice' authority view page in staff, so the link would have to go to the standard MARC view.

Katrin, you are right. It was the OPAC that includes the magnifying glass icon. This improvement will be very useful to distinguish between access points linked to authority records and other without authority record. In my library for example we have a lot of records that include subjects linked to authority records and subjects without authority record.

Yes, I think it woudl be an useful enhancement. For the staff side I think it would not be a big problem to point to the MARC view, even if a prettier view would be nice :)

Created attachment 70666 [details] [review]
Bug 16427 - Direct link to authority records missing staff detail view

I added a magnigying glass icon in the staff detail view that links to the authority records.

Test Plan:
1) On the Koha staff page, create a new authority. The type of authority will be: Topical Term.
2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter the topical term or geographic name entry element and then save the new authority e.g. science.
3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details.
4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED
ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title).
5) Edit the Topical term or geographic name entry element by clicking the button on the right of the bar.
6) In the Search main heading ($a only) enter your topical term e.g. science.
7) Press search, and then in the table that pops up, click 'choose'.
8) Save your edits and the new topical term will be in the 'Subject(s)' list of the book details.
9) Notice that there is no magnifying glass icon.
10) Apply this patch
11) Notice that there is now a magnifying glass icon next to the topical term.
12) Click on the magnifying glass and it will take you directly to the authorities records

This looks good, but can I suggest one minor edit? I think a little space before the icon would improve readability:

             <xsl:if test="marc:subfield[@code=9]">
+                <xsl:text> </xsl:text>
                 <a class='authlink'>

The XSL usually ignores whitespace, so the <xsl:text> block can put a single space before the icon.

Created attachment 70708 [details] [review]
Bug 16427 - Direct link to authority records missing staff detail view

Thanks Owen, I've just added the whitespace before the magnifying glass.

Created attachment 70742 [details] [review]
Bug 16427: Direct link to authority records missing staff detail view

I added a magnigying glass icon in the staff detail view that links to
the authority records.

Test Plan:
1) On the Koha staff page, create a new authority. The type of authority
   will be: Topical Term.
2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter
   the topical term or geographic name entry element and then save the
   new authority e.g. science.
3) In circulation, search the catalog for a random book. Click the title
   of the book and you will be taken to the book details.
4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED
   ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title).
5) Edit the Topical term or geographic name entry element by clicking
   the button on the right of the bar.
6) In the Search main heading ($a only) enter your topical term e.g.
   science.
7) Press search, and then in the table that pops up, click 'choose'.
8) Save your edits and the new topical term will be in the 'Subject(s)'
   list of the book details.
9) Notice that there is no magnifying glass icon.
10) Apply this patch
11) Notice that there is now a magnifying glass icon next to the topical
    term.
12) Click on the magnifying glass and it will take you directly to the
    authorities records

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Thanks for the follow-up! I squashed the two patches during sign-off for simplicity's sake.

This works perfectly for the subjects, but not for the authors and contributurs (1xx, 7xx), would it be possible to get another patch for the others to complete this? I have filed bug 20362 so this can move on.

Created attachment 72552 [details] [review]
Bug 16427: Add direct link to authority records from staff detail view (MARC21 subjects)

I added a magnigying glass icon in the staff detail view that links to
the authority records.

Test Plan:
1) On the Koha staff page, create a new authority. The type of authority
   will be: Topical Term.
2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter
   the topical term or geographic name entry element and then save the
   new authority e.g. science.
3) In circulation, search the catalog for a random book. Click the title
   of the book and you will be taken to the book details.
4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED
   ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title).
5) Edit the Topical term or geographic name entry element by clicking
   the button on the right of the bar.
6) In the Search main heading ($a only) enter your topical term e.g.
   science.
7) Press search, and then in the table that pops up, click 'choose'.
8) Save your edits and the new topical term will be in the 'Subject(s)'
   list of the book details.
9) Notice that there is no magnifying glass icon.
10) Apply this patch
11) Notice that there is now a magnifying glass icon next to the topical
    term.
12) Click on the magnifying glass and it will take you directly to the
    authorities records

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Pushed to master for 18.05, thanks to everybody involved!

Enhancement, not backported for 17.11