Summary: | C4::Tags is not plack safe | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | abl, brendan, f.demians, julian.maurice, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 7172, 16455 | ||
Attachments: |
Bug 16444: Make C4::Tags plack safe
Bug 16444: Make C4::Tags plack safe [SIGNED-OFF] Bug 16444: Make C4::Tags plack safe Bug 16444: Make C4::Tags plack safe |
Description
Jonathan Druart
2016-05-04 19:20:36 UTC
Created attachment 51222 [details] [review] Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Created attachment 51244 [details] [review] Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Created attachment 51373 [details] [review] [SIGNED-OFF] Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Mine now, qa guys :) (In reply to Jonathan Druart from comment #1) > There is not test plan, just make sure the changes are consistent. These are the best :) Created attachment 52027 [details] [review] Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to Master - Should be in the November 2016 Release. Thanks Pushed in 16.05. Will be in 16.05.01. Patch pushed to 3.22.x, will be in 3.22.8 |