Bug 16444

Summary: C4::Tags is not plack safe
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: abl, brendan, f.demians, julian.maurice, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 7172, 16455    
Attachments: Bug 16444: Make C4::Tags plack safe
Bug 16444: Make C4::Tags plack safe
[SIGNED-OFF] Bug 16444: Make C4::Tags plack safe
Bug 16444: Make C4::Tags plack safe

Description Jonathan Druart 2016-05-04 19:20:36 UTC
C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe.
Comment 1 Jonathan Druart 2016-05-04 19:22:01 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-05-05 14:53:39 UTC Comment hidden (obsolete)
Comment 3 Srdjan Jankovic 2016-05-10 06:04:46 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2016-06-04 06:50:33 UTC
Mine now, qa guys :)
Comment 5 Marcel de Rooy 2016-06-04 07:40:10 UTC
(In reply to Jonathan Druart from comment #1)
> There is not test plan, just make sure the changes are consistent.

These are the best :)
Comment 6 Marcel de Rooy 2016-06-04 07:42:21 UTC
Created attachment 52027 [details] [review]
Bug 16444: Make C4::Tags plack safe

C4::Tags use a package variable to cache the pref
TagsExternalDictionary, it's not needed and not safe.

There is not test plan, just make sure the changes are consistent.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Brendan Gallagher 2016-06-04 07:54:57 UTC
Pushed to Master - Should be in the November 2016 Release.  Thanks
Comment 8 Frédéric Demians 2016-06-15 07:38:07 UTC
Pushed in 16.05. Will be in 16.05.01.
Comment 9 Julian Maurice 2016-06-16 08:24:26 UTC
Patch pushed to 3.22.x, will be in 3.22.8