| Summary: | Allow librarians to add borrowers to patron lists by borrowernumber | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Liz Rea <liz> |
| Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, kyle, m.de.rooy, nick, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 16446: Add ability to add patrons to list by borrowernumber
Bug 16446: Add ability to add patrons to list by borrowernumber Bug 16446: (follow-up) Fix translation and adjust radio buttons Bug 16446: Add ability to add patrons to list by borrowernumber Bug 16446: (follow-up) Fix translation and adjust radio buttons |
||
|
Description
Liz Rea
2016-05-05 00:47:34 UTC
Giving this a bump. I'm training a library that wants to batch modify patrons who lack cardnumbers. +1 There is an option to enter cardnumbers now, but no option for borrowernumbers. Changing the bug title slightly. Created attachment 124177 [details] [review] Bug 16446: Add ability to add patrons to list by borrowernumber AddPatronsToList already took a borrowernumber parameter, however, it did not check if those were valid numbers. This patch expands the search to apply to cardnumber or borrowernumbers in the subroutine. Template and script are adjusted to allow choosing borrowernumbers or cardnumbers To test: 1 - Apply patch 2 - Browse to Tools->Patron lists 3 - Create a list, or choose Actions->Add patrons for an existing list 4 - Click 'Add multiple patrons' 5 - Cardnumbers is preselected 6 - Enter a list of cardnumbers, ensure you test: Cardnumber already in list Cardnumber not in list Non-existent cardnumber 7 - Patrons should be added/errors reported correctly 8 - Repeat with borowernumbers Created attachment 124182 [details] [review] Bug 16446: Add ability to add patrons to list by borrowernumber AddPatronsToList already took a borrowernumber parameter, however, it did not check if those were valid numbers. This patch expands the search to apply to cardnumber or borrowernumbers in the subroutine. Template and script are adjusted to allow choosing borrowernumbers or cardnumbers To test: 1 - Apply patch 2 - Browse to Tools->Patron lists 3 - Create a list, or choose Actions->Add patrons for an existing list 4 - Click 'Add multiple patrons' 5 - Cardnumbers is preselected 6 - Enter a list of cardnumbers, ensure you test: Cardnumber already in list Cardnumber not in list Non-existent cardnumber 7 - Patrons should be added/errors reported correctly 8 - Repeat with borowernumbers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Nice try, Nick, but you have been caught by the translation police ;) + <tr><th>[% id_column | html FILTER ucfirst %] not found</th></tr> This is only one of the lines I think are not good. Please make sure cardnumber or borrowernumber remain translatable throughout instead of using the variables to replace the text. Otherwise this looks pretty good to me. QA tools and tests pass. As translation length of strings may vary I think I'd like the text for the radio box after the radio box instead of below. It kind of looks strange to me that there are not center or beginning of the text now. Created attachment 124242 [details] [review] Bug 16446: (follow-up) Fix translation and adjust radio buttons Created attachment 126623 [details] [review] Bug 16446: Add ability to add patrons to list by borrowernumber AddPatronsToList already took a borrowernumber parameter, however, it did not check if those were valid numbers. This patch expands the search to apply to cardnumber or borrowernumbers in the subroutine. Template and script are adjusted to allow choosing borrowernumbers or cardnumbers To test: 1 - Apply patch 2 - Browse to Tools->Patron lists 3 - Create a list, or choose Actions->Add patrons for an existing list 4 - Click 'Add multiple patrons' 5 - Cardnumbers is preselected 6 - Enter a list of cardnumbers, ensure you test: Cardnumber already in list Cardnumber not in list Non-existent cardnumber 7 - Patrons should be added/errors reported correctly 8 - Repeat with borowernumbers Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 126624 [details] [review] Bug 16446: (follow-up) Fix translation and adjust radio buttons Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |