Summary: | "Borrow Permission" should not be used anymore | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | brendan, gmcharlt, julian.maurice, kyle.m.hall, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 7976 | ||
Bug Blocks: | |||
Attachments: |
Bug 16447: Remove occurrence of the borrow permission which does no longer exist
Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 16447: Remove occurrence of the borrow permission which does no longer exist [PASSED QA] Bug 16447: Remove occurrence of the borrow permission which does no longer exist |
Description
Jonathan Druart
2016-05-05 13:51:03 UTC
Created attachment 51231 [details] [review] Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl and opac/svc/login should have been removed by bug 16447. Test plan: git grep 'borrow => 1' should not return any results. (In reply to Jonathan Druart from comment #1) (...) > Note that the occurrences in sendbasket.pl and opac/svc/login should > have been removed by bug 16447. We are on Bug 16447 - mistake of bug number? > Test plan: > git grep 'borrow => 1' > should not return any results. Is OK, but git grep 'borrow ' finds additonally: edithelp.pl: borrow => 1, t/db_dependent/Auth.t: borrow => 0 Created attachment 51246 [details] [review] Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. (In reply to Marc Véron from comment #2) > (In reply to Jonathan Druart from comment #1) > (...) > > Note that the occurrences in sendbasket.pl and opac/svc/login should > > have been removed by bug 16447. > We are on Bug 16447 - mistake of bug number? > > > Test plan: > > git grep 'borrow => 1' > > should not return any results. > > Is OK, but git grep 'borrow ' finds additonally: > > edithelp.pl: borrow => 1, > t/db_dependent/Auth.t: borrow => 0 Good catches, fixed! Created attachment 51253 [details] [review] Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 51262 [details] [review] [PASSED QA] Bug 16447: Remove occurrence of the borrow permission which does no longer exist Bug 7976 has removed this permission, but other patches re-added it... Note that the occurrences in sendbasket.pl, edithelp.pl, opac/svc/login should have been removed by bug 7976. Test plan: git grep 'borrow.*=> 1' should not return any results. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master - Should be in the May 2016 release. Thanks! Patch pushed to 3.22.x, will be in 3.22.7 |