Bug 16454

Summary: Use "inventory" instead of "inventory/stocktaking"
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: aleisha, julian.maurice, kyle
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/tools/inventory.pl
Change sponsored?: Sponsored Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'
Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'
[SIGNED-OFF] Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'
Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'
Bug 16454: Remove another occurrence in comment

Description Owen Leonard 2016-05-05 15:04:49 UTC
We don't say "check out/issue" or "patron/member," so I don't think we should use "inventory/stocktaking." Let's just say "inventory."
Comment 1 Aleisha Amohia 2016-05-12 04:49:29 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2016-05-12 12:08:38 UTC
This looks great, but it occurred to me to look for other forms of "stocktaking." I see some instances of "inventory (stocktaking)":

/includes/permissions.inc:
/modules/help/members/member-flags.tt:
/modules/tools/tools-home.tt:
Comment 3 Aleisha Amohia 2016-05-12 21:41:08 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2016-05-14 21:55:12 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-05-16 11:12:05 UTC
Created attachment 51522 [details] [review]
Bug 16454: Use 'inventory' instead of 'inventory/stocktaking'

To test:
1) Go to the tools home page. Confirm it says 'Inventory' instead of
   'Inventory/stocktaking' in heading and in description
2) Click Inventory. Confirm heading now says 'Inventory' instead of
   'Inventory/stocktaking'
3) Confirm that it now says 'Inventory' instead of
   'Inventory/stocktaking' in the tools menu along the left of the page
4) Click Help in top right corner. Confirm help heading now says
   'Inventory' instead of 'Inventory/stocktaking'
5) Go to user account page, go to Set Permissions
6) Expand Tools option and confirm it says 'inventory' instead of
   'inventory (stocktaking)'

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2016-05-16 11:12:09 UTC
Created attachment 51523 [details] [review]
Bug 16454: Remove another occurrence in comment

Note that few other occurrences exist in DB.

This patch also replaces a tab with 4 spaces.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Kyle M Hall 2016-05-16 17:44:18 UTC
Pushed to master for 16.05, thanks Aleisha, Jonathan!
Comment 8 Julian Maurice 2016-06-09 07:45:50 UTC
Patches pushed to 3.22.x, will be in 3.22.8