Summary: | Remove the use of "onclick" from some catalog pages | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | f.demians, kyle, nchatzakis, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 16781 | ||
Attachments: |
Bug 16469 - Remove the use of "onclick" from some catalog pages
Bug 16469 - Remove the use of "onclick" from some catalog pages Bug 16469 - Remove the use of "onclick" from some catalog pages |
Description
Owen Leonard
2016-05-06 16:42:03 UTC
Created attachment 51298 [details] [review] Bug 16469 - Remove the use of "onclick" from some catalog pages This patch removes the use of "onclick" attributes from two catalog-related templates: The local cover image viewer and the search results page. Events are now defined in JavaScript. To test: On the search results page: - Perform a catalog search which will return multiple results. - On the search results page, confirm that the "Select all" and "Clear all" links at the top of the results table work correctly. In the local cover image viewer: - The LocalCoverImages and AllowMultipleCovers system preferences must enabled, and at least one catalog record must have at least two local cover images attached. - Locate that record in the catalog and view the detail page for it. - Click the cover image in the "Images" tab to go to the image viewer page. - Clicking each local cover image thumnail should correctly display the larger version of each image. Select and Clear buttons seems to work at staff interface but not at the OPAC. Tested both at master and with this patch applied, so we will sign off Patch tested with a sandbox, by Nikos Chatzakis, Afrodite Malliari <nchatzakis@datascouting.com> Created attachment 51978 [details] [review] Bug 16469 - Remove the use of "onclick" from some catalog pages This patch removes the use of "onclick" attributes from two catalog-related templates: The local cover image viewer and the search results page. Events are now defined in JavaScript. To test: On the search results page: - Perform a catalog search which will return multiple results. - On the search results page, confirm that the "Select all" and "Clear all" links at the top of the results table work correctly. In the local cover image viewer: - The LocalCoverImages and AllowMultipleCovers system preferences must enabled, and at least one catalog record must have at least two local cover images attached. - Locate that record in the catalog and view the detail page for it. - Click the cover image in the "Images" tab to go to the image viewer page. - Clicking each local cover image thumnail should correctly display the larger version of each image. https://bugs.koha-community.org/show_bug.cgi?id=16249 Signed-off-by: Nikos Chatzakis, Afrodite Malliari <nchatzakis@datascouting.com> Created attachment 52643 [details] [review] Bug 16469 - Remove the use of "onclick" from some catalog pages This patch removes the use of "onclick" attributes from two catalog-related templates: The local cover image viewer and the search results page. Events are now defined in JavaScript. To test: On the search results page: - Perform a catalog search which will return multiple results. - On the search results page, confirm that the "Select all" and "Clear all" links at the top of the results table work correctly. In the local cover image viewer: - The LocalCoverImages and AllowMultipleCovers system preferences must enabled, and at least one catalog record must have at least two local cover images attached. - Locate that record in the catalog and view the detail page for it. - Click the cover image in the "Images" tab to go to the image viewer page. - Clicking each local cover image thumnail should correctly display the larger version of each image. Signed-off-by: Nikos Chatzakis, Afrodite Malliari <nchatzakis@datascouting.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for Koha 16.11, thanks Owen! Pushed in 16.05. Will be in 16.05.02. |