Created attachment 51334 [details]
Screenshots with broken display
Created attachment 51336 [details] [review] Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts To test: - Make sure that syspref OnsiteCheckouts is enabled - Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled - Go to 'your reading history' (in English) - Display all three tabs - Apply patch - Reload page, display oll three tabs again, there should be no difference - Examine source code changes to verify that the words 'checkout' and 'onsite' no longer will be exposed to translation. Created attachment 51337 [details] [review] Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts To test: - Make sure that syspref OnsiteCheckouts is enabled - Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled - Go to 'your reading history' (in English) - Display all three tabs - Apply patch - Reload page, display oll three tabs again, there should be no difference - Examine source code changes to verify that the words 'checkout' and 'onsite' no longer will be exposed to translation. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 51338 [details] [review] Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 51342 [details] [review] Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 51602 [details] [review] [PASSED QA] Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts To test: - Make sure that syspref OnsiteCheckouts is enabled - Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled - Go to 'your reading history' (in English) - Display all three tabs - Apply patch - Reload page, display oll three tabs again, there should be no difference - Examine source code changes to verify that the words 'checkout' and 'onsite' no longer will be exposed to translation. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 51603 [details] [review] [PASSED QA] Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 16.05, thanks Marc, Jonathan! Patches pushed to 3.22.x, will be in 3.22.7 |
In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt the filter for the tabs 'Checkouts' and 'On-site checkouts' uses text that is exposed to translation. If they are translated, the tabs will be empty on translated pages. (Note: Enable syspref OnSiteCheckuts for testing) See opac-readingrecord.tt line 83ff: [% IF issue.onsite_checkout %] onsite [% ELSE %] checkout [% END %] E.g. in German (/de-DE/modules/opac-readingrecord.tt), it translates to: [% IF issue.onsite_checkout %] vor Ort [% ELSE %] ausgeliehen [% END %] It should be the same as in the English version. A very dirty workaround would be not to translate 'onsite' and 'checkout' in Pootle. Most problably other language will fall into this trap as well.