Summary: | Report menu has unexpected issues | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | Reports | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | julian.maurice, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 15421 | ||
Bug Blocks: | |||
Attachments: |
Snapshot of menu failure
Snapshot of good menu (how it should look) Bug 16481 - Report menu has unexpected issues [SIGNED-OFF] Bug 16481 - Report menu has unexpected issues Bug 16481 - Report menu has unexpected issues |
Description
Christopher Brannon
2016-05-09 17:31:18 UTC
Created attachment 51340 [details]
Snapshot of menu failure
Created attachment 51341 [details]
Snapshot of good menu (how it should look)
Created attachment 51343 [details] [review] Bug 16481 - Report menu has unexpected issues This patch corrects a problem with the reports toolbar include file which can cause a problem with the "duplicate" button. The duplicate button passes the entire report SQL as a URL parameter, but the template variable was not escaped as a URL variable. This patch also adds the "uri" filter to the report name and notes fields just to be safe. To reproduce the bug, create a new SQL report using the SQL in the bug report. When you run the report you should see a broken "Duplicate" button. Apply the patch and run the report again. The duplicate button should look correct and work correctly. Created attachment 51352 [details] [review] [SIGNED-OFF] Bug 16481 - Report menu has unexpected issues This patch corrects a problem with the reports toolbar include file which can cause a problem with the "duplicate" button. The duplicate button passes the entire report SQL as a URL parameter, but the template variable was not escaped as a URL variable. This patch also adds the "uri" filter to the report name and notes fields just to be safe. To reproduce the bug, create a new SQL report using the SQL in the bug report. When you run the report you should see a broken "Duplicate" button. Apply the patch and run the report again. The duplicate button should look correct and work correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 51404 [details] [review] Bug 16481 - Report menu has unexpected issues This patch corrects a problem with the reports toolbar include file which can cause a problem with the "duplicate" button. The duplicate button passes the entire report SQL as a URL parameter, but the template variable was not escaped as a URL variable. This patch also adds the "uri" filter to the report name and notes fields just to be safe. To reproduce the bug, create a new SQL report using the SQL in the bug report. When you run the report you should see a broken "Duplicate" button. Apply the patch and run the report again. The duplicate button should look correct and work correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for Koha 16.05, thanks Owen! Patch pushed to 3.22.x, will be in 3.22.7 |