| Summary: | Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet (titles not showing in lists) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Lists | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, julian.maurice, kyle, m.de.rooy, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16296 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet
Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet |
||
|
Description
Nick Clemens (kidclamp)
2016-05-09 23:28:11 UTC
Created attachment 51354 [details] [review] Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet To test: 1 - Create a list in staff client 2 - Set XSLTResultsDisplay to blank 3 - View list, titles don't display 4 - Apply patch 5 - View list, titles display 6 - Set XSLTResultsDisplay to default 7 - View list, titles display as before patch Created attachment 51375 [details] [review] Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet To test: 1 - Create a list in staff client 2 - Set XSLTResultsDisplay to blank 3 - View list, titles don't display 4 - Apply patch 5 - View list, titles display 6 - Set XSLTResultsDisplay to default 7 - View list, titles display as before patch Signed-off-by: Marc Véron <veron@veron.ch> opac-shelves.pl and virtualshelves/shelves.pl have diverged in this area. The OPAC script calls GetBiblioData, which populated title and other infos. It would make sense to add the call to the staff script to avoid different behaviors between these 2 scripts. The eternal question is: should we continue to fix non-XSLT views? :) Created attachment 51634 [details] [review] Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet To test: 1 - Create a list in staff client 2 - Set XSLTResultsDisplay to blank 3 - View list, titles don't display 4 - Apply patch 5 - View list, titles display 6 - Set XSLTResultsDisplay to default 7 - View list, titles display as before patch Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Jonathan Druart from comment #3) > The eternal question is: should we continue to fix non-XSLT views? :) If we deprecate something, we should make more definitive plans to remove the functionality too imo. Since this is just a one-line fix restoring something very fundamental as the title of a book, I would recommend to push it. Did you see my other concern about the divergence of the 2 files? (In reply to Jonathan Druart from comment #6) > Did you see my other concern about the divergence of the 2 files? Yes. These scripts should not contain so much logic. (In reply to Jonathan Druart from comment #6) > Did you see my other concern about the divergence of the 2 files? I know it was not introduced by this patch, but it would be good to fix it (even on another bug report). But... it would be easiest to remove the code than to fix it... (In reply to Jonathan Druart from comment #8) > (In reply to Jonathan Druart from comment #6) > > Did you see my other concern about the divergence of the 2 files? > > I know it was not introduced by this patch, but it would be good to fix it > (even on another bug report). But... it would be easiest to remove the code > than to fix it... I would recommend now to build on top of this one liner (tested etc.) New adjustments will not reach 16.05 anymore. Pushed to master for 16.05, thanks Nick! Patch pushed to 3.22.x, will be in 3.22.7 |