|
Description
Theodoros Theodoropoulos
2016-05-10 11:03:55 UTC
Needless to say that in my case the authorized values for the collections are correct and collection names appear correctly in other result pages. Hi Theodoros, It seems to be related to the field biblioitems.collectiontitle which is only used by UNIMARC users. Julian, could you confirm? I confirm that the "Collection" column display data from biblioitems.collectiontitle. I don't know if it's specific to UNIMARC users. (In reply to Julian Maurice from comment #3) > I don't know if it's specific to UNIMARC users. It's all NULL in our MARC21 database, for what it's worth. Also In our MARC21 system, ALL ~1m items have NULL in biblioitems.collectiontitle Created attachment 53332 [details]
Showing Z39.50 search results with and without MarcEdit XSLT applied
Oops, sorry, I meant to attach this to a different bug. Comment on attachment 53332 [details]
Showing Z39.50 search results with and without MarcEdit XSLT applied
Obsoleted the screenshot :)
It seems there is a confusion between Collection code and collection title. Collection code is selected as filter, but only collection title appear in results display. Both column should appear. Suggestion: we only show collectiontitle for UNIMARC or we change the name of the column to be clear it's not the collection from the item. I'd prefer the first a bit, and also, to show hte real collection in the search. It's an important item information and missing at the moment. Created attachment 64682 [details] [review] Bug 16485: collection column in Item search is always empty This patch fills the column 'Collection' in item search from the item values. To test: - Go to item search - Reproduce issue from initial comment - Apply patch - Verify that the column 'Collection' is filled Still to do, but outside of my datatable skills: Filter by drop down in the column header does a substring search. Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items. Setting to NSO to get comments. If somebody wants to take over (for the datatable filter issue) please feel free to do so. (In reply to Marc Véron from comment #12) > Setting to NSO to get comments. > > If somebody wants to take over (for the datatable filter issue) please feel > free to do so. Regarding the filter problem: jQuery DataTable ColumnFilter plugin. Can the “select” filter style support exact match? https://stackoverflow.com/questions/9520423/jquery-datatable-columnfilter-plugin-can-the-select-filter-style-support-exac I opened a new bug for that, because other datatable columns with filters of type select are affected as well: Bug 18961 - Datatable column filters of style 'select' should do an exact match BTW, patch still applies... Created attachment 65395 [details] [review] [SIGNED-OFF] Bug 16485: collection column in Item search is always empty This patch fills the column 'Collection' in item search from the item values. To test: - Go to item search - Reproduce issue from initial comment - Apply patch - Verify that the column 'Collection' is filled Still to do, but outside of my datatable skills: Filter by drop down in the column header does a substring search. Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This solution works well for me as a MARC21 user. I agree that a separate bug is the right place for the matching issue. Since this changes the way the search works for UNIMARC users I think it would be good to get an additional signoff from someone who can test with UNIMARC data. Patch tested with a sandbox, by Laurence Rault <laurence.rault@biblibre.com> Created attachment 66553 [details] [review] Bug 16485: collection column in Item search is always empty This patch fills the column 'Collection' in item search from the item values. To test: - Go to item search - Reproduce issue from initial comment - Apply patch - Verify that the column 'Collection' is filled Still to do, but outside of my datatable skills: Filter by drop down in the column header does a substring search. Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Tested OK on sandbox with UNIMARC configuration ; with the patch the items.ccode is displayed in column Collection Created attachment 66729 [details] [review] Bug 16485: collection column in Item search is always empty This patch fills the column 'Collection' in item search from the item values. To test: - Go to item search - Reproduce issue from initial comment - Apply patch - Verify that the column 'Collection' is filled Still to do, but outside of my datatable skills: Filter by drop down in the column header does a substring search. Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.05. Thank you all for your time and effort into fixing this bug! FYI, the patch seems to work fine (with a small offset), even in older, non-maintained Koha versions (ie 3.2x) ps. A further update would be to consider populating the dropdown menu with the CCODES of the results ONLY instead of all the CCODES, but for the time being I think this is impossible. This patch has been pushed to 16.11.x and will be in 16.11.13. Pushed to 16.05.x, for 16.05.18 release |