| Summary: | circulation.pl logs warnings about Use of uninitialized value | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | julian.maurice, kyle, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14015 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl
[SIGNED-OFF] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl Bug 16499 [QA Followup] - Improve readability |
||
|
Description
Jonathan Druart
2016-05-11 14:05:48 UTC
Created attachment 51436 [details] [review] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 Created attachment 51440 [details] [review] [SIGNED-OFF] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 51635 [details] [review] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 51721 [details] [review] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 51722 [details] [review] Bug 16499 [QA Followup] - Improve readability Pushed to master for 16.05, thanks Jonathan! Patches pushed to 3.22.x, will be in 3.22.7 |