Summary: | showListsUpdate JS function is not defined at the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | julian.maurice, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12233 | ||
Bug Blocks: | |||
Attachments: |
Bug 16516: Define the showListsUpdate JS function at the OPAC
[SIGNED-OFF] Bug 16516: Define the showListsUpdate JS function at the OPAC Bug 16516: Define the showListsUpdate JS function at the OPAC |
Description
Jonathan Druart
2016-05-13 18:25:59 UTC
Created attachment 51480 [details] [review] Bug 16516: Define the showListsUpdate JS function at the OPAC Bug 12233 removes the declaration of the showListsUpdate JS function for the OPAC. It results in a JS error (ReferenceError: showListsUpdate is not defined) when a user tries to add selected titles to a list if no title is selected. Test plan: Launch a catalogue search Select a list in the "Select titles to" dropdown list => Without this patch you will get the JS error => With this patch you will get a JS alert "No item was selected" Created attachment 51492 [details] [review] [SIGNED-OFF] Bug 16516: Define the showListsUpdate JS function at the OPAC Bug 12233 removes the declaration of the showListsUpdate JS function for the OPAC. It results in a JS error (ReferenceError: showListsUpdate is not defined) when a user tries to add selected titles to a list if no title is selected. Test plan: Launch a catalogue search Select a list in the "Select titles to" dropdown list => Without this patch you will get the JS error => With this patch you will get a JS alert "No item was selected" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 51633 [details] [review] Bug 16516: Define the showListsUpdate JS function at the OPAC Bug 12233 removes the declaration of the showListsUpdate JS function for the OPAC. It results in a JS error (ReferenceError: showListsUpdate is not defined) when a user tries to add selected titles to a list if no title is selected. Test plan: Launch a catalogue search Select a list in the "Select titles to" dropdown list => Without this patch you will get the JS error => With this patch you will get a JS alert "No item was selected" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for Koha 16.05, thanks Jonathan! Patch pushed to 3.22.x, will be in 3.22.7 |