| Summary: | A server error is raised when creating a new list with an existing name | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Lists | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | julian.maurice, kyle, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14544 | ||
| Bug Blocks: | 16519 | ||
| Attachments: |
Bug 16517: Do not crash when creating a list with an existing name
[SIGNED-OFF] Bug 16517: Do not crash when creating a list with an existing name [PASSED QA] Bug 16517: Do not crash when creating a list with an existing name |
||
|
Description
Jonathan Druart
2016-05-13 19:17:42 UTC
For my defense it looks like a merge conflict error when rebasing bug 14544, but I plead guilty :) Created attachment 51482 [details] [review] Bug 16517: Do not crash when creating a list with an existing name A typo has been made during a merge conflict when rebasing bug 16517. it should be eval { Koha::Object->new->store; }; instead of eval { Koha::Object->new; }->store; Test plan: From the result list (intranet side), check some entries and add them to a new list Use an existing list's name => Without this patch you will get a server error (exception 'Duplicate shelf object' raised by Koha::Virtualshelf->new->store) => With this patch you must get a friendly error message Created attachment 51491 [details] [review] [SIGNED-OFF] Bug 16517: Do not crash when creating a list with an existing name A typo has been made during a merge conflict when rebasing bug 16517. it should be eval { Koha::Object->new->store; }; instead of eval { Koha::Object->new; }->store; Test plan: From the result list (intranet side), check some entries and add them to a new list Use an existing list's name => Without this patch you will get a server error (exception 'Duplicate shelf object' raised by Koha::Virtualshelf->new->store) => With this patch you must get a friendly error message Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 51604 [details] [review] [PASSED QA] Bug 16517: Do not crash when creating a list with an existing name A typo has been made during a merge conflict when rebasing bug 16517. it should be eval { Koha::Object->new->store; }; instead of eval { Koha::Object->new; }->store; Test plan: From the result list (intranet side), check some entries and add them to a new list Use an existing list's name => Without this patch you will get a server error (exception 'Duplicate shelf object' raised by Koha::Virtualshelf->new->store) => With this patch you must get a friendly error message Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for Koha 16.05, thanks Jonathan! Patch pushed to 3.22.x, will be in 3.22.7 |