| Summary: | Libraries and groups showing empty tables if nothing defined | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | System Administration | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | brendan, f.demians, gmcharlt, jonathan.druart, julian.maurice |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Empty groups tables
Bug 16523: Groups showing empty tables if no groups defined Bug 16532: Groups showing empty tables if no groups defined Bug 16532: Groups showing empty tables if no groups defined [SIGNED-OFF] Bug 16532: Groups showing empty tables if no groups defined Bug 16532: Groups showing empty tables if no groups defined |
||
Created attachment 51560 [details] [review] Bug 16523: Groups showing empty tables if no groups defined To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Created attachment 51561 [details] [review] Bug 16532: Groups showing empty tables if no groups defined To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Can we do the same for libraries? Even with no libraries defined, "[% IF libraries.size %]" always evaluates as true. Why? > Even with no libraries defined, "[% IF libraries.size %]" always evaluates
> as true. Why?
Jonathan explained to me in IRC that because "libraries" is an object (from Koha::Libraries) we should use "count" instead:
[% IF libraries.count %]...
Created attachment 51730 [details] [review] Bug 16532: Groups showing empty tables if no groups defined EDIT: Same change for libraries To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Created attachment 51767 [details] [review] [SIGNED-OFF] Bug 16532: Groups showing empty tables if no groups defined EDIT: Same change for libraries To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 51803 [details] [review] Bug 16532: Groups showing empty tables if no groups defined EDIT: Same change for libraries To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the November 2016 Release. Thanks! Pushed in 16.05. Will be in 16.05.01. Not needed in 3.22.x |
Created attachment 51558 [details] Empty groups tables