| Summary: | Koha::Cache is incorrectly caching single holidays | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | blocker | ||
| Priority: | P3 | CC: | gwilliams, jonathan.druart, julian.maurice, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14522 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16539 - Koha::Cache is incorrectly caching single holidays
Bug 16539 - Koha::Cache is incorrectly caching single holidays Bug 16539 - Koha::Cache is incorrectly caching single holidays Bug 16539: Try to provide tests Bug 16539: Try to provide tests Bug 16539 - Koha::Cache is incorrectly caching single holidays Bug 16539: Add tests |
||
|
Description
Nick Clemens (kidclamp)
2016-05-17 18:38:36 UTC
Created attachment 51585 [details] [review] Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached Created attachment 51587 [details] [review] Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 51588 [details] [review] Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 51593 [details] [review] Bug 16539: Try to provide tests Nick, I have tried to provide tests for this change, but they pass even without your patch. Could you have a look? Created attachment 51664 [details] [review] Bug 16539: Try to provide tests Fix minor typo (testing CPL not MPL) For me tests fail without patch and pass with it, back to signed off (In reply to Jonathan Druart from comment #5) > Nick, I have tried to provide tests for this change, but they pass even > without your patch. > Could you have a look? Created attachment 51665 [details] [review] Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 51666 [details] [review] Bug 16539: Add tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.05. Thanks Nick, Jonathan! Patches pushed to 3.22.x, will be in 3.22.7 |