Description
Barton Chittenden
2016-05-18 20:01:15 UTC
16:11 < cait> barton: koha doesn't work as login fro me to check out your latest bug 16:13 < barton> ok, I'll check that. 16:13 < barton> thanks. 16:14 < barton> cait: sorry, it's bywater/bywater. I'll update the bug. 16:14 < cait> aah :) It's by design, with multi holds the next available item is automatically selected. I'd say this is more an enhancement request than a bug. Maybe we could send the user to the normal holds page if only one record was selected? Created attachment 97296 [details] [review] Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Patch no longer applies. Created attachment 99072 [details] [review] Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Created attachment 99121 [details] [review] Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind <david@davidnind.com> Created attachment 101992 [details] [review] Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind <david@davidnind.com> Created attachment 102002 [details] [review] Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 Created attachment 102570 [details] [review] Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= https://bugs.koha-community.org/show_bug.cgi?id=24547 Created attachment 102571 [details] [review] Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= Quick test plan for Jonathan's patch: 1 perform search that returns multiple titles 2 select two titles and click Place Hold from results page 3 select patron 4 change pickup location, click Place Hold 5 get taken to page that says "Place hold on No Title" 6 look at the two titles you'd meant to place holds on -- holds do place, but we don't get any confirmation screen 7 apply patch 8 repeat steps 1-4 9 get taken to Confirm Holds page that lists the titles on which you just placed holds Created attachment 102573 [details] [review] Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 102608 [details] [review] Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Thanks Andrew and Nick! enhancement no backported to 19.11.x Nice work everyone! Pushed to master for 20.05 Jonathan, Can the work you've done here be applied to the cart? If so, I could create a ticket suggesting that enhancement. (In reply to Christopher Brannon from comment #19) > Jonathan, > Can the work you've done here be applied to the cart? If so, I could create > a ticket suggesting that enhancement. What exactly? I have tested on master and I see the item info for a single hold and the "multi holds view" if more than 1 is selected. |