| Summary: | Regression caused by 15877 - t/db_dependent/Barcodes.t deletes all items from a DB | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Test Suite | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | jonathan.druart, julian.maurice, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15877 | ||
| Bug Blocks: | 15878 | ||
| Attachments: |
Bug 16561 - Followup to fix tests
Bug 16561 - Bug 15877 followup to fix tests |
||
|
Description
Nick Clemens (kidclamp)
2016-05-22 00:13:44 UTC
Created attachment 51689 [details] [review] Bug 16561 - Followup to fix tests When I altered the tests to avoid accidental deletion of all items, I didn't rollback the transaction, hence the tests now delete all items from a db when run. This patch rollsback the transaction so items are not deleted from your db To test: 1 - Backup your db 2 - prove -v t/db_dependent/Barcodes.t 3 - Note that all items and issues are deleted from the DB 4 - Restore your DB 5 - Apply this patch 6 - prove -v t/db_dependent/Barcodes.t 7 - Your DB should eb unchanged Created attachment 51693 [details] [review] Bug 16561 - Bug 15877 followup to fix tests When I altered the tests to avoid accidental deletion of all items, I didn't rollback the transaction, hence the tests now delete all items from a db when run. This patch rollsback the transaction so items are not deleted from your db To test: 1 - Backup your db 2 - prove -v t/db_dependent/Barcodes.t 3 - Note that all items and issues are deleted from the DB 4 - Restore your DB 5 - Apply this patch 6 - prove -v t/db_dependent/Barcodes.t 7 - Your DB should eb unchanged Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I have amended the patch to fix alignment and commit message (to display bug 15877). Skipping QA as it's a trivial one. Pushed to master for Koha 16.05, thanks Nick! Patch pushed to 3.22.x, will be in 3.22.7 |