| Summary: | additional_fields and additional_field_values are not dropped in kohastructure.sql | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | brendan, f.demians, julian.maurice, m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10855 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 16565: Drop additional_fields and additional_field_values before creating them
Bug 16565: Drop additional_fields and additional_field_values before creating them Bug 16565: Drop additional_fields and additional_field_values before creating them |
||
|
Description
Jonathan Druart
2016-05-23 11:19:27 UTC
Created attachment 51717 [details] [review] Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: From the SQL CLI, source the kohastructure.sql file source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Created attachment 51811 [details] [review] Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: From the SQL CLI, source the kohastructure.sql file source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 51944 [details] [review] Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: From the SQL CLI, source the kohastructure.sql file source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to Master - Should be in the November 2016 release. Thanks! Pushed in 16.05. Will be in 16.05.01. Patch pushed to 3.22.x, will be in 3.22.8 |