Summary: | 'Print slip' button formatting inconsistent | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | boutrosboutrosboutros, f.demians, gmcharlt, katrin.fischer, kyle.m.hall, kyle, lisettepalouse+koha, veron |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 16566 - 'Print slip' button formatting inconsistent
Bug 16566 - 'Print slip' button formatting inconsistent Screenshot: Please return item to: Midway Bug 16566 [Revised] 'Print slip' button formatting inconsistent Bug 16566 [Revised] 'Print slip' button formatting inconsistent |
Description
Nick Clemens
2016-05-23 13:24:54 UTC
(In reply to Nick Clemens from comment #0) > > https://snag.gy/YOlr50.jpg We obviously have another problem here too: Two transfer messages? Shouldn't the rotating collection transfer message supersede the "normal" one? Created attachment 51791 [details] [review] Bug 16566 - 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. (In reply to Owen Leonard from comment #1) > (In reply to Nick Clemens from comment #0) > > > > https://snag.gy/YOlr50.jpg > > We obviously have another problem here too: Two transfer messages? Shouldn't > the rotating collection transfer message supersede the "normal" one? Same opinion. I think this should be covered by another bug. Created attachment 51902 [details] [review] Bug 16566 - 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. Followed test plan. Buttons appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 52551 [details]
Screenshot: Please return item to: Midway
First test I did: Return a checked out item at another branch than it's been checked out from. The button shown doesn't work for me - no visible Javascript error.
In the browser's page source, the url provided is: data-url="transfer-slip.pl?transferitem=298&branchcode=CPL&op=slip" If I copy it in the browser's address field I have to replace & with & to make it work. Created attachment 52694 [details] [review] Bug 16566 [Revised] 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. Followed test plan. Buttons appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Revision following QA: Removed redundant class attribute from the print button tested in step 1. Created attachment 52860 [details] [review] Bug 16566 [Revised] 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. Followed test plan. Buttons appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Revision following QA: Removed redundant class attribute from the print button tested in step 1. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 16.11, thanks Owen! Pushed in 16.05. Will be in 16.05.02. This patch creates another bug: When confirming transfer and print slip, the print-slip popup winwod appears, but when it returns, the transfer is not effected. (because of e.preventDefault(), the form event is never processed) (In reply to Petter Goksøyr Åsen from comment #11) > This patch creates another bug: > When confirming transfer and print slip, the print-slip popup winwod > appears, but when it returns, the transfer is not effected. (because of > e.preventDefault(), the form event is never processed) As this has been pushed to stable, I would recommend you file a new bug report detailing the issue. |