Summary: | Remove the use of "onclick" from several templates | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | f.demians, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 16778 | ||
Attachments: |
Bug 16602 - Remove the use of "onclick" from several templates
Bug 16602 - Remove the use of "onclick" from several templates Bug 16602 - Remove the use of "onclick" from several templates |
Description
Owen Leonard
2016-05-26 14:28:44 UTC
Created attachment 51845 [details] [review] Bug 16602 - Remove the use of "onclick" from several templates This patch removes the use of "onclick" from several templates, instead defining click events in JavaScript. Also changed: Some markup corrections. To test, apply the patch and: - Go to Circulation -> Upload offline circulation file - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). - Go to Patrons -> Patron lists. - For any patron list containing patrons, click the 'Print patron cards' menu item. This should trigger a modal window which exports the correct list. - Go to Tools -> Batch item modification. - Submit a batch of items for modification. - Clicking the 'Save' button should trigger the background job and the items should be successfully modified. - Go to Tools -> Batch item deletion. - Submit a batch of items for deletion. - Clicking the 'Delete' button should trigger the background job and the items should be successfully deleted. - Go to Tools -> Calendar. - Trigger the 'Add new holiday' panel by clicking a day on the calendar which has no holiday defined. - Clicking the 'Cancel' link should hide the panel. - Trigger the 'Edit this holiday' panel by clicking a day which has a holiday defined. - Clicking the 'Cancel' link should hide the panel. Created attachment 51893 [details] [review] Bug 16602 - Remove the use of "onclick" from several templates This patch removes the use of "onclick" from several templates, instead defining click events in JavaScript. Also changed: Some markup corrections. To test, apply the patch and: - Go to Circulation -> Upload offline circulation file - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). - Go to Patrons -> Patron lists. - For any patron list containing patrons, click the 'Print patron cards' menu item. This should trigger a modal window which exports the correct list. - Go to Tools -> Batch item modification. - Submit a batch of items for modification. - Clicking the 'Save' button should trigger the background job and the items should be successfully modified. - Go to Tools -> Batch item deletion. - Submit a batch of items for deletion. - Clicking the 'Delete' button should trigger the background job and the items should be successfully deleted. - Go to Tools -> Calendar. - Trigger the 'Add new holiday' panel by clicking a day on the calendar which has no holiday defined. - Clicking the 'Cancel' link should hide the panel. - Trigger the 'Edit this holiday' panel by clicking a day which has a holiday defined. - Clicking the 'Cancel' link should hide the panel. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Everything works as previously. Created attachment 52645 [details] [review] Bug 16602 - Remove the use of "onclick" from several templates This patch removes the use of "onclick" from several templates, instead defining click events in JavaScript. Also changed: Some markup corrections. To test, apply the patch and: - Go to Circulation -> Upload offline circulation file - Browse for an offline circulation file. - Clicking the 'Upload file' button should work correctly. - After uploading a file, both the 'Add to offline circulation queue' and 'Apply directly' buttons should work to trigger their corresponding processes (keeping Bug 16603 in mind). - Go to Patrons -> Patron lists. - For any patron list containing patrons, click the 'Print patron cards' menu item. This should trigger a modal window which exports the correct list. - Go to Tools -> Batch item modification. - Submit a batch of items for modification. - Clicking the 'Save' button should trigger the background job and the items should be successfully modified. - Go to Tools -> Batch item deletion. - Submit a batch of items for deletion. - Clicking the 'Delete' button should trigger the background job and the items should be successfully deleted. - Go to Tools -> Calendar. - Trigger the 'Add new holiday' panel by clicking a day on the calendar which has no holiday defined. - Clicking the 'Cancel' link should hide the panel. - Trigger the 'Edit this holiday' panel by clicking a day which has a holiday defined. - Clicking the 'Cancel' link should hide the panel. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Everything works as previously. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Owen! Pushed in 16.05. Will be in 16.05.02. |